Merged
Conversation
8 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configuration option to disable the '_' (underscore) keybind that opens the current working directory, allowing users to use the default Vim motion behavior instead.
- Added
disableUnderscoreOpenCwdconfiguration setting with appropriate description - Implemented conditional keymap registration based on the new setting
- Updated VSCode keybinding conditions to respect the configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vim/oil.code.lua |
Added conditional registration of the '_' keybind based on configuration setting |
src/utils/settings.ts |
Added getter function for the new configuration option |
package.json |
Added configuration schema and updated keybinding condition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add config to disable '_' keybind
📝 Description
This PR adds a config option to disable the '_' keybind
🔧 Type of Change
🔗 Related Issues
Resolves #49
Testing
Screenshots (if applicable)
Checklist
Additional Notes