LuaBindings - fix some ownership semantics #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causeless
approved these changes
Jan 25, 2026
Merged
via the queue into
cortex-command-community:development
with commit Jan 25, 2026
428b7b4
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up some ownership semantics policies on some lua bindings. In particular, many methods on
Vectorneeded these.I didn't check everything, there's so many of them; for instance, I don't know how exactly policies are applied to
.propertygetter/setter pairs, or if these have any default policies or not, so I didn't do anything with these.Still though:
Fixes #230