Open
Conversation
Paolo costruttori
Paolo costruttori
… fanta components
…dal components Complete signal migration for leaderboard and password-change-modal: - Update leaderboard template to use showVotes() and maxDisplayable() accessors - Fix leaderboard to use dbData.users() and dbData.tracks() signals - Convert password-change-modal @input to input() decorator - Update password modal template with proper signal accessor syntax - Fix form field bindings to use [ngModel]/signal.set() pattern - Update modal visibility and loading state to use signal accessors - Update spec tests to use signal-based access patterns
Migrate loading, season, and twitch-api services: - loading.service: Replace BehaviorSubject with signal, expose readonly loading signal - season.service: Replace BehaviorSubject with signal, remove .getValue() pattern - twitch-api.service: Convert isLive to signal-based state, simplify getter method - Update loading.service spec to test signal-based state instead of observables - All services now expose readonly signals via asReadonly() pattern - Remove RxJS dependencies from service state management
- db-data.service: Remove redundant getter methods (getAllDrivers, getChampionship, etc.) - Components now directly access readonly signals (allDrivers(), championship(), etc.) - fanta.service: Update to use dbData signals (drivers(), constructorGrandPrixPoints()) - vote-history-table: Update to use allDrivers() and constructors() signals - Simplifies API surface and enforces signal-first access pattern
Update all view components to use new signal API from services: - championship: Use championship() signal directly - dashboard-charts-data: Use cumulativePoints() and tracks() signals - dashboard: Use allDrivers(), tracks(), constructors(), cumulativePoints() signals - fanta: Use allDrivers(), tracks(), constructors() signals - piloti: Use allDrivers() and constructors() signals - Update dashboard spec to properly mock signal-based twitch service - All views now consistently access service data through readonly signals
Migrate link-box and loading-spinner components: - link-box: Convert @input decorators to input() functions - link-box: Replace OnDestroy with effect() + DestroyRef for resize listener cleanup - link-box: Use signal for isLargeScreen state, update template with accessors - loading-spinner: Remove observable subscription, use loading signal directly - loading-spinner: Update template from async pipe to signal accessor syntax - Add ChangeDetectionStrategy.OnPush to link-box for consistency
Cleanup wrong dependency
Commented out github workflow angular tests
Fanta, constructors and tests fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.