Merge pull request RustPython#3964 from youknowone/fix-windows-ci

update subprocess for windows

Author: youknowone

Lib/subprocess.py

@@ -207,7 +207,8 @@ def Detach(self):
         def __repr__(self):
             return "%s(%d)" % (self.__class__.__name__, int(self))
 
-        __del__ = Close
+        # XXX: RustPython; OSError('The handle is invalid. (os error 6)')
+        # __del__ = Close
 else:
     # When select or poll has indicated that the file is writable,
     # we can write up to _PIPE_BUF bytes without risk of blocking.

Lib/test/test_subprocess.py

@@ -3599,18 +3599,12 @@ def test_kill(self):
     def test_terminate(self):
         self._kill_process('terminate')
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_send_signal_dead(self):
         self._kill_dead_process('send_signal', signal.SIGTERM)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_kill_dead(self):
         self._kill_dead_process('kill')
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_terminate_dead(self):
         self._kill_dead_process('terminate')
 
@@ -3713,14 +3707,6 @@ def test__all__(self):
             possible_exports.add(name)
         self.assertEqual(exported, possible_exports - intentionally_excluded)
 
-    # TODO: RUSTPYTHON
-    if sys.platform == "win32":
-        test_call_keyboardinterrupt_no_kill = unittest.expectedFailure(test_call_keyboardinterrupt_no_kill)
-
-    # TODO: RUSTPYTHON
-    if sys.platform == "win32":
-        test_run_keyboardinterrupt_no_kill = unittest.expectedFailure(test_run_keyboardinterrupt_no_kill)
-
     # TODO: RUSTPYTHON
     if sys.platform == "win32":
         test_getoutput = unittest.expectedFailure(test_getoutput)