Skip to content

Commit 7fdbf53

Browse files
committed
update subprocess for windows
1 parent fff5a8c commit 7fdbf53

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

Lib/subprocess.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,8 @@ def Detach(self):
207207
def __repr__(self):
208208
return "%s(%d)" % (self.__class__.__name__, int(self))
209209

210-
__del__ = Close
210+
# XXX: RustPython; OSError('The handle is invalid. (os error 6)')
211+
# __del__ = Close
211212
else:
212213
# When select or poll has indicated that the file is writable,
213214
# we can write up to _PIPE_BUF bytes without risk of blocking.

Lib/test/test_subprocess.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3599,18 +3599,12 @@ def test_kill(self):
35993599
def test_terminate(self):
36003600
self._kill_process('terminate')
36013601

3602-
# TODO: RUSTPYTHON
3603-
@unittest.expectedFailure
36043602
def test_send_signal_dead(self):
36053603
self._kill_dead_process('send_signal', signal.SIGTERM)
36063604

3607-
# TODO: RUSTPYTHON
3608-
@unittest.expectedFailure
36093605
def test_kill_dead(self):
36103606
self._kill_dead_process('kill')
36113607

3612-
# TODO: RUSTPYTHON
3613-
@unittest.expectedFailure
36143608
def test_terminate_dead(self):
36153609
self._kill_dead_process('terminate')
36163610

@@ -3713,14 +3707,6 @@ def test__all__(self):
37133707
possible_exports.add(name)
37143708
self.assertEqual(exported, possible_exports - intentionally_excluded)
37153709

3716-
# TODO: RUSTPYTHON
3717-
if sys.platform == "win32":
3718-
test_call_keyboardinterrupt_no_kill = unittest.expectedFailure(test_call_keyboardinterrupt_no_kill)
3719-
3720-
# TODO: RUSTPYTHON
3721-
if sys.platform == "win32":
3722-
test_run_keyboardinterrupt_no_kill = unittest.expectedFailure(test_run_keyboardinterrupt_no_kill)
3723-
37243710
# TODO: RUSTPYTHON
37253711
if sys.platform == "win32":
37263712
test_getoutput = unittest.expectedFailure(test_getoutput)

0 commit comments

Comments
 (0)