-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(cli): curl/irl installation scripts and docs #9835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Review Complete Code Review Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 issues found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="extensions/cli/scripts/install.sh">
<violation number="1" location="extensions/cli/scripts/install.sh:149">
P2: `set -u` plus unguarded `$FNM_DIR` expansion in `source_fnm` will abort the installer when FNM_DIR is unset.</violation>
<violation number="2" location="extensions/cli/scripts/install.sh:182">
P2: Cleanup can remove an existing fnm installation because CLEANUP_FNM is set unconditionally without tracking whether the install directory pre-existed.</violation>
</file>
<file name="extensions/cli/scripts/install.ps1">
<violation number="1" location="extensions/cli/scripts/install.ps1:173">
P2: Direct-download fnm install only updates the current session PATH; no persistent PATH update is written, so new shells may not find `fnm` and the profile init will fail after restart.</violation>
<violation number="2" location="extensions/cli/scripts/install.ps1:274">
P2: User-local npm prefix is only added to the current session PATH; after restarting PowerShell the CLI may not be on PATH, so `cn` can be missing despite a successful install.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Fix CLEANUP_FNM to only mark for cleanup if fnm dir doesn't pre-exist - Guard FNM_DIR expansion with parameter substitution to avoid set -u errors - Persist fnm PATH to user environment in PowerShell for future sessions - Persist npm global bin PATH to user environment in PowerShell Co-authored-by: dallin <dallin@continue.dev> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
…t-perform-those-actions-for-you- fix: address code review comments for installation scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 19 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="extensions/cli/README.md">
<violation number="1" location="extensions/cli/README.md:12">
P2: Docs now recommend `curl|bash`/`irm|iex` of scripts from the moving `main` branch without pinning or integrity verification, which creates a supply‑chain risk and non‑reproducible installs.</violation>
</file>
<file name="docs/guides/posthog-github-continuous-ai.mdx">
<violation number="1" location="docs/guides/posthog-github-continuous-ai.mdx:1">
P2: Frontmatter delimiter is corrupted (`20---`), so the YAML metadata won’t be parsed as frontmatter and can break MDX metadata/builds.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Description
Continue Tasks:▶️ 1 queued · ✅ 1 merged — View all
Summary by cubic
Adds cross-platform one-line installers for Continue CLI that auto-install Node.js 20+ when needed and streamline setup. Updates docs to auto-detect OS and show the right command, making onboarding faster.
Written for commit 045021a. Summary will update on new commits.