-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: retrieve reasoning toggle from local storage #9688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct could we store this per model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="gui/src/hooks/ParallelListeners.tsx">
<violation number="1" location="gui/src/hooks/ParallelListeners.tsx:91">
P2: Legacy `hasReasoningEnabled` preference is ignored; existing users with it set to false will default back to enabled after the new per-model key lookup.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Persists reasoning setting per model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct could you use the existing redux persist gate to persist these values rather than a separate local storage key? So that there's not 2 sources of truth. Sorry missed that on first review.
Note persisting this in local storage on top of YAML setting could be confusing to some users because once the user toggles it, the defaultCompletionOptions.reasoning setting in the model config will be permanently out of sync with the local storage value if it is set to true (The false setting will still be respected with current logic). This is the main reason we haven't put tool policies in YAML config. It's an issue whether persisted per model or not. Thoughts on this?
This makes sense - it will be out of sync when local storage is used. Sorry I too missed this in my first approach. Implemented changes! |
Description
Get and store
hasReasoningEnabledin local storage so that when thinking toggle is manually turned off, it does not turn on workspace reload.closes #9675
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
before.mp4
after.mp4
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Continue Tasks
Powered by Continue
Summary by cubic
Persist and restore the reasoning toggle per model using the Redux UI slice so the user’s choice sticks across reloads and doesn’t auto-enable when switching to reasoning-capable models.
Written for commit 649491a. Summary will update on new commits.