Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Jan 20, 2026

Description

Get and store hasReasoningEnabled in local storage so that when thinking toggle is manually turned off, it does not turn on workspace reload.

closes #9675

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Continue Tasks

Status Task Actions
▶️ Queued Update docs on PR View

Powered by Continue


Summary by cubic

Persist and restore the reasoning toggle per model using the Redux UI slice so the user’s choice sticks across reloads and doesn’t auto-enable when switching to reasoning-capable models.

  • Bug Fixes
    • Save hasReasoningEnabled per model via ui.reasoningSettings on toggle in InputToolbar.
    • Read per-model setting from Redux in ParallelListeners and combine with model support and reasoning=false configs.

Written for commit 649491a. Summary will update on new commits.

@uinstinct uinstinct requested a review from a team as a code owner January 20, 2026 04:04
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team January 20, 2026 04:04
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 20, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct could we store this per model?

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="gui/src/hooks/ParallelListeners.tsx">

<violation number="1" location="gui/src/hooks/ParallelListeners.tsx:91">
P2: Legacy `hasReasoningEnabled` preference is ignored; existing users with it set to false will default back to enabled after the new per-model key lookup.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Persists reasoning setting per model

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jan 26, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 26, 2026
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct could you use the existing redux persist gate to persist these values rather than a separate local storage key? So that there's not 2 sources of truth. Sorry missed that on first review.

Note persisting this in local storage on top of YAML setting could be confusing to some users because once the user toggles it, the defaultCompletionOptions.reasoning setting in the model config will be permanently out of sync with the local storage value if it is set to true (The false setting will still be respected with current logic). This is the main reason we haven't put tool policies in YAML config. It's an issue whether persisted per model or not. Thoughts on this?

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Jan 26, 2026
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 27, 2026
@uinstinct
Copy link
Contributor Author

@uinstinct could you use the existing redux persist gate to persist these values rather than a separate local storage key? So that there's not 2 sources of truth. Sorry missed that on first review.

Note persisting this in local storage on top of YAML setting could be confusing to some users because once the user toggles it, the defaultCompletionOptions.reasoning setting in the model config will be permanently out of sync with the local storage value if it is set to true (The false setting will still be respected with current logic). This is the main reason we haven't put tool policies in YAML config. It's an issue whether persisted per model or not. Thoughts on this?

This makes sense - it will be out of sync when local storage is used. Sorry I too missed this in my first approach.

Implemented changes!

@uinstinct uinstinct requested a review from RomneyDa January 27, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Thinking toggle forgets state on window reload

2 participants