fix(core): normalize workspace dir paths to file:// URIs

[BillionClaw]

Description

Fixes #11559 - File Path Resolution Failure in Tools

When IDE extensions (e.g., IntelliJ on Linux) return workspace directories as plain file paths like /home/user/project instead of proper file:// URIs, the path resolution logic would produce incorrect double-prefixed paths like /home/user/home/user/project.

Root Cause

The resolveRelativePathInDir() and inferResolvedUriFromRelativePath() functions in core/util/ideUtils.ts expected workspace directories to always be in URI format (file:///home/user/project), but some IDE extensions return plain filesystem paths.

Fix

Added normalizeDirUri() helper that converts plain file paths to proper file:// URIs before joining with relative paths:

• Handles Linux absolute paths (/home/user/project)
• Handles Windows paths (C:\\Users\\project)
• Passes through already-valid URIs unchanged
• Handles vscode-remote:// and other schemes

Tests

Added core/util/ideUtils.vitest.ts with tests for:

• normalizeDirUri() - URI passthrough, Linux paths, Windows paths, encoding
• resolveRelativePathInDir() - normal case, bug case, regression guard
• inferResolvedUriFromRelativePath() - normal case, bug case, regression guard

Checklist

• I've read the contributing guide
• The relevant tests have been created

---

Summary by cubic

Normalize workspace directory paths to file:// URIs to fix path resolution when IDEs return plain paths (e.g., IntelliJ on Linux). Prevents double-prefixed paths and ensures correct URI joining.

• Bug Fixes
  • Added normalizeDirUri to convert Linux/Windows paths; passthrough for existing URIs and other schemes.
  • Updated resolveRelativePathInDir and inferResolvedUriFromRelativePath to normalize dir inputs.
  • Added tests for normalization and both resolution functions, including regression guards.

^{Written for commit da335b8. Summary will update on new commits.}

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="core/util/ideUtils.ts">

<violation number="1" location="core/util/ideUtils.ts:31">
P2: UNC Windows workspace paths are not normalized to `file://` URIs, so network-share directories can still bypass the new fix and break relative-path URI resolution.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: UNC Windows workspace paths are not normalized to file:// URIs, so network-share directories can still bypass the new fix and break relative-path URI resolution.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At core/util/ideUtils.ts, line 31:

<comment>UNC Windows workspace paths are not normalized to `file://` URIs, so network-share directories can still bypass the new fix and break relative-path URI resolution.</comment>

<file context>
@@ -6,6 +6,36 @@ import {
+  }
+
+  // For Windows paths (C:\ or drive letters)
+  if (/^[a-zA-Z]:/.test(dirPath)) {
+    const normalized = dirPath.replaceAll("\\", "/");
+    return `file:///${pathToUriPathSegment(normalized)}`;
</file context>