refactor: update MySQL details structure in LoadUploadFile and Migrat…#1021
Closed
refactor: update MySQL details structure in LoadUploadFile and Migrat…#1021
Conversation
…ion components - Changed property name from mySQLDetails to mysql for consistency across components. - Updated references in LoadUploadFile and Migration to align with the new property structure. - Removed unnecessary useEffect hooks to streamline component logic.
AishDani
force-pushed
the
feature/cmg-852
branch
from
25fa9f2 to
3199459
Compare
vikrantraut
reviewed
Mar 31, 2026
| } | ||
| }, | ||
| mysql: { | ||
| host: uploadObj?.file_details?.mysql?.host || newMigrationDataRef?.current?.legacy_cms?.uploadedFile?.file_details?.mysql?.host, |
There was a problem hiding this comment.
you can optimized this code
const fromUpload = uploadObj?.file_details;
const fromLegacy =
newMigrationDataRef?.current?.legacy_cms?.uploadedFile?.file_details;
mysql: {
host: fromUpload?.mysql?.host || fromLegacy?.mysql?.host,
user: fromUpload?.mysql?.user || fromLegacy?.mysql?.user,
database: fromUpload?.mysql?.database || fromLegacy?.mysql?.database,
port: fromUpload?.mysql?.port || fromLegacy?.mysql?.port,
},
assetsConfig: {
base_url: fromUpload?.assetsConfig?.base_url || fromLegacy?.assetsConfig?.base_url,
public_path:
fromUpload?.assetsConfig?.public_path || fromLegacy?.assetsConfig?.public_path,
},
Contributor
Author
|
not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion components