Skip to content

Feature/wordpress#1019

Merged
vikrantraut merged 22 commits intodevfrom
feature/wordpress
Mar 31, 2026
Merged

Feature/wordpress#1019
vikrantraut merged 22 commits intodevfrom
feature/wordpress

Conversation

@AishDani
Copy link
Copy Markdown
Contributor

No description provided.

@AishDani AishDani requested a review from a team as a code owner March 30, 2026 07:59
vikrantraut
vikrantraut previously approved these changes Mar 30, 2026
vikrantraut
vikrantraut previously approved these changes Mar 30, 2026
…dependencies, and add license information for several packages
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the migration UI to carry and display additional WordPress/SQL-related configuration (MySQL connection details and assets config) as part of the uploaded file metadata, while also refreshing several dependencies/lockfiles across the repo.

Changes:

  • Extend FileDetails and migration state mapping to include mysql connection info and assetsConfig fields.
  • Update legacy CMS upload/validation UI to read/write the new mysql shape and adjust when Redux state is dispatched/refreshed.
  • Bump dependency versions and regenerate lockfiles (UI + upload-api), plus add an undici override in the API package.

Reviewed changes

Copilot reviewed 7 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
upload-api/package.json Updates @typescript-eslint plugin/parser versions.
upload-api/package-lock.json Lockfile refresh to match dependency updates.
upload-api/migration-aem/package-lock.json Lockfile refresh/removals for migration-aem package.
ui/tests/unit/store/authSlice.test.ts Silences console.error during an error-path test.
ui/src/pages/Migration/index.tsx Maps config/project data into migration state, now including mysql + assetsConfig.
ui/src/context/app/app.interface.ts Renames FileDetails MySQL field to mysql.
ui/src/components/LegacyCms/Actions/LoadUploadFile.tsx Updates MySQL rendering and changes dispatch/effect behavior during validation.
ui/package.json Bumps @contentstack/venus-components and adds @testing-library/dom.
ui/package-lock.json Lockfile refresh to match UI dependency updates.
api/package.json Adds an undici override entry.
Files not reviewed (3)
  • ui/package-lock.json: Language not supported
  • upload-api/migration-aem/package-lock.json: Language not supported
  • upload-api/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

ui/src/context/app/app.interface.ts:64

  • This interface renames mySQLDetails to mysql, but there is still code constructing/reading file_details.mySQLDetails (e.g., ui/src/components/LegacyCms/Actions/LoadSelectCms.tsx:153). That will cause type errors and likely runtime missing data. Either update all remaining call sites to mysql, or keep backwards compatibility by supporting both properties during a transition.
    bucketName?: string;
    bucketKey?: string;
  };
  mysql?: {
    host?: string;
    user?: string;
    database?: string;
    port?: number;
  };

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@umeshmore45
Copy link
Copy Markdown
Contributor

@vikrantraut-cstk please approve

@vikrantraut vikrantraut merged commit ff3bd8e into dev Mar 31, 2026
9 checks passed
@vikrantraut vikrantraut deleted the feature/wordpress branch March 31, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants