-
Notifications
You must be signed in to change notification settings - Fork 0
Update axios version to v1.12.0, patch version for launch-cli package, packages for security issues, license year and use runtime cwd for data-dir flag. #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Harshi-Shah-CS <harshi.shah@contentstack.com> Co-authored-by: Aryan Bansal <aryan.bansal@contentstack.com> Co-authored-by: SakshiKoli-CS <sakshi.koli@contentstack.com>
chore: Update axios and express version
Update express version to v4.22.0 and Axios version to v1.12.0
fix: use runtime cwd for data-dir flag
Use runtime cwd for data-dir flag
chore:update patch version
Update patch version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR makes three changes: updates the axios dependency version, fixes the data-dir flag to use runtime process.cwd() evaluation, and bumps the package version.
Changes:
- Updates axios from ~1.10.0 to ~1.12.0 (resolves to 1.12.2 in lockfile)
- Fixes data-dir flag to evaluate process.cwd() at runtime instead of at module load time
- Bumps package version from 1.9.4 to 1.9.5
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/commands/launch/functions.ts | Removes default value from data-dir flag and adds runtime cwd evaluation with fallback logic |
| src/commands/launch/functions.test.ts | Adds test case to verify fallback behavior when data-dir is not provided |
| package.json | Updates axios version to ~1.12.0 and bumps package version to 1.9.5 |
| package-lock.json | Updates axios to 1.12.2 and reflects package version change |
| .talismanrc | Updates checksum for package-lock.json changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Harshi-Shah-CS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
chore: update packages for security issues
Update packages for security issues
e79b870
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chore: Update license year
Update license year
d47aef7
dhruvparekh12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
chore: update axios version to v1.12.0
fix: use runtime cwd for data-dir flag
chore:update patch version
chore: update packages for security issues
chore: Update license year