Nt 2695 handle optimized entry children visibility during the sdk lifecycle#176
Open
Lotfi Anwar L Arif (Lotfi-Arif) wants to merge 9 commits intomainfrom
Conversation
- Update README with render-prop, wrapper element, and layout-neutral behavior details. - Add nesting guard documentation and implementation to block nested Personalization with duplicate baseline entry IDs. - Add lifecycle and nesting tests for Personalization component. - Refine loading fallback and baseline personalizable logic.
Render a concrete element with `data-ctfl-loading-layout-target` during loading, ensuring layout and visibility remain targetable even when using `display: contents`. Adds tests for block and inline wrapper cases.
- Introduce `lifecycleMode` prop for SPA and hybrid SSR-SPA rendering - Render invisible loading target during SSR in hybrid mode - Block nested wrappers with duplicate baseline entry IDs at runtime - Update docs and tests for new lifecycle behavior
- Baseline content now renders invisibly during SSR or first hydration frame. - Non-personalized entries are no longer gated behind sdkInitialized. - Tests and documentation updated to reflect new readiness logic.
…bility-during-the-sdk-lifecycle
Lotfi Anwar L Arif (Lotfi-Arif)
requested review from
Alex Freas (akfreas) and
Charles Hudson (phobetron)
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Personalizationto safely support consumer-provided content as either:(resolvedEntry) => ReactNode)OptimizedEntry/Personalizationfrom being nested with the same baseline entry ID.display: contents, while allowing semantic wrapper selection viaas="div" | "span"(defaultdiv).data-ctfl-loading-layout-target) so fallback UI remains styleable/targetable even when wrapper usesdisplay: contents.lifecycleModeAPI):canPersonalize === true