Google Docs: Modal cleanup [INTEG-3233]#10693
Merged
Franco Banfi (FBanfi) merged 14 commits intogoogle-docs-hilfrom Mar 16, 2026
Merged
Google Docs: Modal cleanup [INTEG-3233]#10693Franco Banfi (FBanfi) merged 14 commits intogoogle-docs-hilfrom
Franco Banfi (FBanfi) merged 14 commits intogoogle-docs-hilfrom
Conversation
…1] (#10674) * feat: implement pagination for content type fetching in SelectContentTypeModal * fix: add checks to avoid infinite loop
* feat(google-docs): make the test modal more dev friendly * fix(google-docs): cleanup content type ids and spacing
Franco Banfi (FBanfi)
force-pushed
the
google-docs-hil
branch
from
394e607 to
bc7c2f5
Compare
# Conflicts: # apps/google-docs/src/hooks/useGeneratePreview.ts # apps/google-docs/src/hooks/useModalManagement.ts # apps/google-docs/src/locations/Page/components/mainpage/ModalOrchestrator.tsx # apps/google-docs/src/locations/Page/components/modals/step_2/SelectContentTypeModal.tsx
Harika Kondur (harikakondur)
approved these changes
Mar 16, 2026
Harika Kondur (harikakondur)
added a commit
that referenced
this pull request
Mar 23, 2026
) * feat: extend timeout to 50 minutes and add in timing markers (#10608) * fix: update AGENT_ANALYZER_ID constant to reflect new workflow agent name (#10613) * removing hook * Google Docs: Modal cleanup [INTEG-3233] (#10693) * feat: extend timeout to 50 minutes and add in timing markers (#10608) * fix: update AGENT_ANALYZER_ID constant to reflect new workflow agent name (#10613) * fix: update local agents API URL to use constant for base URL * fix(google-docs): add pagination for content type fetching [INTEG-3491] (#10674) * feat: implement pagination for content type fetching in SelectContentTypeModal * fix: add checks to avoid infinite loop * chore: add env example * chore: update readme * fix: cleanup test modal [INTEG-3496] (#10682) * feat(google-docs): make the test modal more dev friendly * fix(google-docs): cleanup content type ids and spacing * cleaning unnecessary steps * adding close button for first step * removing unused custom hook and usages * solving conflicts in merge --------- Co-authored-by: ryunsong-contentful <124832189+ryunsong-contentful@users.noreply.github.com> Co-authored-by: Harika Kondur <107296300+harikakondur@users.noreply.github.com> Co-authored-by: harika kondur <harika.kondur@contentful.com> * Google Docs: Adding select tabs step [INTEG-3534] (#10704) * feat: extend timeout to 50 minutes and add in timing markers (#10608) * fix: update AGENT_ANALYZER_ID constant to reflect new workflow agent name (#10613) * fix: update local agents API URL to use constant for base URL * fix(google-docs): add pagination for content type fetching [INTEG-3491] (#10674) * feat: implement pagination for content type fetching in SelectContentTypeModal * fix: add checks to avoid infinite loop * chore: add env example * chore: update readme * fix: cleanup test modal [INTEG-3496] (#10682) * feat(google-docs): make the test modal more dev friendly * fix(google-docs): cleanup content type ids and spacing * cleaning unnecessary steps * adding close button for first step * adding select tabs step * removing unused custom hook and usages * solving conflicts in merge * adding select tabs step * removing unused hook * adding select tabs modal tests * wip changing tabs modal step * refactors and fixing multiselect bug * refactoring selected tabs and content types modals * fixing build errors * adding truncation in content types selection * addressing PR comments * changing onClose from tabs step * addressing pr comments * changing selected tabs setter usage --------- Co-authored-by: ryunsong-contentful <124832189+ryunsong-contentful@users.noreply.github.com> Co-authored-by: Harika Kondur <107296300+harikakondur@users.noreply.github.com> Co-authored-by: harika kondur <harika.kondur@contentful.com> * Google Docs - UI: Modal for Images step and refactor [MAPS-3528] (#10712) * feat: extend timeout to 50 minutes and add in timing markers (#10608) * fix: update AGENT_ANALYZER_ID constant to reflect new workflow agent name (#10613) * fix: cleanup test modal [INTEG-3496] (#10682) * feat(google-docs): make the test modal more dev friendly * fix(google-docs): cleanup content type ids and spacing * cleaning unnecessary steps * adding select tabs modal tests * wip changing tabs modal step * Refactor modal management by removing the useModalManagement hook and integrating modal state directly into ModalOrchestrator. Added IncludeImagesModal component and its tests. Updated related modals to streamline the user flow and improve modal handling. * Add tests for IncludeImagesModal and update SelectTabsModal tests to reflect new button actions * Naming refactors * Enhance progress tracking by adding includeImages state and integrating it into ModalOrchestrator. Updated modals to support image inclusion and refined button actions in SelectTabsModal. Adjusted LoadingModal to accept onClose prop for better modal management. * Refactor modal actions to use 'onContinue' instead of 'onConfirm' for improved clarity. Updated IncludeImagesModal and SelectContentTypeModal to reflect this change, along with corresponding tests. Added state management for includeImages in useProgressTracking. * Remove TODO comment for preview step in ModalOrchestrator and add IncludeImagesModal test suite to enhance modal functionality and testing coverage. * fixing tests after merge * formatting with prettier * refactor in error handling --------- Co-authored-by: ryunsong-contentful <124832189+ryunsong-contentful@users.noreply.github.com> Co-authored-by: Harika Kondur <107296300+harikakondur@users.noreply.github.com> Co-authored-by: francobanfi <franco.banfi@external.contentful.com> * Google Docs: Refactor in confirm cancel state [INTEG-3582] (#10717) * refactor in confirm cancel state + deleting unnecessary hooks * adding tests for ModalOrchestrator and ConfirmCancelModal * refactor in include images modal + tests --------- Co-authored-by: ryunsong-contentful <124832189+ryunsong-contentful@users.noreply.github.com> Co-authored-by: francobanfi <franco.banfi@external.contentful.com> Co-authored-by: Franco Banfi <62450599+FBanfi@users.noreply.github.com> Co-authored-by: JuliRossi <juliana.rossi@external.contentful.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pr includes the removal of things that aren't needed in the current google docs app designs.
Approach
Created a
google-docs-hilfeature branch fromgoogle-docs-quality. We’ll create new branches from this feature branch and work there, so the rest of the team can continue usinggoogle-docs-qualityfor their backend demos.Removed unnecessary things that aren't needed in the current google docs app designs:
Testing steps
New tests will be added in future steps
Breaking Changes
This cleanup removes the trigger to the workflow, so if you want to go and trigger the workflow through the frontend, you should do it through the
google-docs-qualitybranch.Dependencies and/or References
Link to designs
Deployment
N/A