ci: declare contents: read on the CI workflow#468
Open
arpitjain099 wants to merge 2 commits into
Open
Conversation
The 9 jobs in ci.yml (checks, windows-checks, tests, timings, deny, linux-integration, windows-integration, results) all run actions/checkout plus build/test steps. None push back to the repo or call write APIs, so contents: read is the right floor. cover.yml / labeler.yml / publish.yml / stale.yml in this repo already declare permissions (per-job). Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Author
|
Hi @mxpv, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
Author
|
Bringing this back to the top of the queue. Happy to fix conflicts or adjust the approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nine jobs in
ci.ymlall runactions/checkoutplus build/test steps. None push or call write APIs, socontents: readat the workflow level is the right minimum.The other CI-adjacent workflows in this repo (
cover.yml,labeler.yml,publish.yml,stale.yml) already declarepermissions:per job; this bringsci.ymlin line with the broader pattern.