Open
Conversation
36e64b2 to
0801fee
Compare
AkihiroSuda
reviewed
Aug 19, 2025
d11a608 to
f4c0f71
Compare
8b9cb17 to
b3ef6e5
Compare
AkihiroSuda
reviewed
Aug 20, 2025
AkihiroSuda
reviewed
Aug 20, 2025
AkihiroSuda
reviewed
Aug 20, 2025
AkihiroSuda
reviewed
Aug 20, 2025
AkihiroSuda
reviewed
Aug 20, 2025
AkihiroSuda
reviewed
Aug 20, 2025
AkihiroSuda
reviewed
Aug 20, 2025
Contributor
Author
There was a problem hiding this comment.
I'm not sure how to connect unix shim or windows shim, does containerd-shim-runc-v2 works well on unix? @AkihiroSuda
Contributor
Author
There was a problem hiding this comment.
config := &Config{
ID: os.Getenv("CONTAINER_ID"),
Namespace: os.Getenv("CONTAINER_NAMESPACE"),
Stdout: os.NewFile(3, "CONTAINER_STDOUT"),
Stderr: os.NewFile(4, "CONTAINER_STDERR"),
}
I'm trying to find a way to avoid call task.Wait or call shim api.
if container main process exited. the pipe reader should know the writer is closed. but I can't find a good way to know pipe writer is closed. @AkihiroSuda
Contributor
Author
There was a problem hiding this comment.
I try get EPOLLHUP event but it doesn’t work.
Contributor
Author
There was a problem hiding this comment.
another way is to monitor /proc/container_pid to know container exited.
b3ef6e5 to
59154c0
Compare
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
59154c0 to
30006b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nerdctl old version call task.Wait to wait container stop, but if containerd stop task.Wait will return. So I find a better way to solve this we can let nerdctl call shim api to get container status.