fix(mime-bytes): detect HEIC/HEIF instead of misidentifying as MP4#1158
Merged
Conversation
Sort fileTypes by magicBytes length descending so that longer (more specific) magic byte patterns are checked before shorter prefixes. This fixes HEIC and HEIF images being misidentified as video/mp4 because both formats share the ISO Base Media File Format 'ftyp' container prefix. Closes #967
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #967. HEIC and HEIF images were misidentified as
video/mp4because all three formats share the ISO Base Media File Formatftypcontainer prefix. Themp4entry (4 magic bytes) appeared beforeheic/heif(8 magic bytes) in the registry, so the shorter prefix matched first.The fix sorts
this.fileTypesbymagicBytes.lengthdescending in theFileTypeDetectorconstructor, ensuring longer (more specific) signatures are checked before shorter prefix patterns.Review & Testing Checklist for Human
.heicphoto from an iPhone that detection returnsimage/heicinstead ofvideo/mp4isombrand) still detect correctly asvideo/mp4Notes
magicBytes.lengthretain their original order.ftypheicbrand) and HEIF (ftypmif1brand) buffers, plus the existing MP4 (ftypisom) test continues to pass.Link to Devin session: https://app.devin.ai/sessions/1db29f3c8a46434c99001ddcb701cc12
Requested by: @pyramation