refactor: update node type registry for per-field _updated_at timestamps#1156
Merged
Conversation
Part of constructive-planning#849
- SearchVector: include_stale_field -> include_updated_at_field,
descriptions updated for {field_name}_updated_at timestamptz
- DataFileEmbedding: same parameter rename and description updates
- DataImageEmbedding: same parameter rename and description updates
- All stale_strategy descriptions updated to reflect new field naming
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…e type registry Simplifies SearchVector, DataFileEmbedding, and DataImageEmbedding: - Remove stale_strategy parameter (was column/null/hash) - Remove include_updated_at_field parameter - _updated_at timestamp is now always created by the SQL generator - Update description to reflect simplified behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
stale_strategyandinclude_updated_at_fieldparameters from the node type registry for SearchVector, DataFileEmbedding, and DataImageEmbedding. The SQL generators now always create{field_name}_updated_atwith no configuration needed.What changed:
SearchVector: removedstale_strategy(was column/null/hash) andinclude_updated_at_fieldparams, updated descriptionDataFileEmbedding: removedstale_strategyandinclude_updated_at_fieldparamsDataImageEmbedding: removedstale_strategyandinclude_updated_at_fieldparamsReview & Testing Checklist for Human
Risk: green — TypeScript-only changes, removing parameters that the SQL generators no longer accept.
stale_strategyorinclude_updated_at_field(if any do, they'll be silently ignored by the SQL generator since it no longer reads those keys)Notes
Link to Devin session: https://app.devin.ai/sessions/2b5a29d83d3f478e8d3d972653b4879c
Requested by: @pyramation