CHORE: Workspace level Cargo.toml

[aakoshh]

Takes some of the changes done in db0002c to make all Cargo.toml files take the dependency versions from a common workspace level one.

What this PR doesn't do is try to change any of the dependency versions. I think we should fight that battle after we have established a working CI pipeline which allows us to work with this repository with confidence.

The PR also doesn't try to reorganise the imported subtree structures, e.g. it leaves them as ipc/ipc and fendermint/fendermint, in the hope that this will make it easier to pull in changes that are still actively happening in those repositories.

#1 started updating dependencies but I would recommend that we rebase that on top of this and refrain from rearranging the code layout until this repository is stable and we stop working on the originals.

Testing

A top level make test delegates to all sub-repos, each having their own make test target focusing on their own packages, excluding everything else.

[aakoshh]

@adlrocha when I look at the original contracts I see symlinks (or submodules?): https://github.com/consensus-shipyard/ipc-solidity-actors/tree/dev/lib

However in this repo these are not pointing anywhere useful: https://github.com/consensus-shipyard/ipc-monorepo/tree/main/contracts/lib

Possibly because you created the subtrees from your local filesystem instead of pulling in the remote repositories. Do you have an idea how to fix it? I don't know how these libraries were added in the first place.

Currently when I try to run tests I get this:

❯ cd contracts

  ~/projects/consensuslab/ipc-monorepo/contracts  workspace-toml ···················································································································· ⬢ 20.9.0  1.73.0 22:06:24
❯ make test
forge test -vvv --ffi
[⠊] Compiling...
Error: 
Failed to resolve file: "/home/aakoshh/projects/consensuslab/ipc-monorepo/contracts/lib/openzeppelin-contracts/contracts/utils/structs/EnumerableSet.sol": No such file or directory (os error 2).
 Check configured remappings..
    --> "/home/aakoshh/projects/consensuslab/ipc-monorepo/contracts/src/gateway/GatewayGetterFacet.sol"
        "openzeppelin-contracts/utils/structs/EnumerableSet.sol"
make: *** [Makefile:50: test] Error 1

[adlrocha]

@aakoshh, usually we use https://book.getfoundry.sh/projects/dependencies#adding-a-dependency to install dependencies. I tried but I get an error flagging that my commit history is dirty (which is not the case). I also tried git submodule update --init --recursive and it says that there's no url found for the submodules (which conflicts with the message above) :( I'll keep tinkering, but to keep you up to date. What forge install does is basically bring the code to the repo as a submodule.

[adlrocha]

LGTM. Left a few comments with reminders, but looks good. I'll try to find how we can pull the Solidity dependencies in the meantime (which is the last thing missing)

[adlrocha]

We should remove them. We were waiting for M2.5 to deprecate them, and now we can. I actually removed them from my monorepo PR already.

Suggested change

	# "ipc/ipc/testing/*",
	# "ipc/ipc/testing/*",

[adlrocha]

As part of the monorepo I would like to deprecate fvm-utils. Now that we don't need the ffi and we use solidity contracts the repo is no longer needed and we can move the primitives to the monorepo directly.

Suggested change

"fvm-utils/runtime",

[aakoshh]

Thanks, I saw that primitives have been moved, just wanted to defer that after it's all done.

[adlrocha]

Here's the command to pull changes so you don't have to look for it:

git subtree pull --prefix external/<component> <component> dev

Source: https://stackoverflow.com/questions/45222656/how-do-i-add-a-subtree-to-an-existing-prefix-in-a-new-clone

[aakoshh]

@adlrocha thanks for fixing the submodules!

When I pull and run make test I get this:

Failed to resolve file: "/home/aakoshh/projects/consensuslab/ipc-monorepo/contracts/lib/forge-std/src/Test.sol": No such file or directory (os error 2).
 Check configured remappings..
    --> "/home/aakoshh/projects/consensuslab/ipc-monorepo/contracts/test/AccountHelper.t.sol"
        "forge-std/Test.sol"

Is there something to be done before?

[aakoshh]

I did the following:

1. remove forge-std from .gitmodules
2. cd contracts/lib; git submodule add https://github.com/foundry-rs/forge-std
3. git submodule update --init --recursive

This fixed running the tests, although they fail for different reasons.

I'm not sure if the 3rd step is a required step for checkout.