This repository was archived by the owner on Dec 10, 2021. It is now read-only.
Support recursive schema#1
Merged
Deadarius merged 7 commits intoconqa:masterfrom May 1, 2019
Deadarius:support-recursive-schema
Merged
Support recursive schema#1Deadarius merged 7 commits intoconqa:masterfrom Deadarius:support-recursive-schema
Deadarius merged 7 commits intoconqa:masterfrom
Deadarius:support-recursive-schema
Conversation
wrumsby
approved these changes
May 1, 2019
neftaly
reviewed
May 1, 2019
|
|
||
| plugins: | ||
| - serverless-openapi-documentation | ||
| localPath: /Users/alex/dev/serverless-openapi-documentation |
neftaly
reviewed
May 1, 2019
| * Walks through the schema object recursively and updates references to point to openapi's components | ||
| * @param schema JSON Schema Object | ||
| */ | ||
| private updateReferences (schema: JSONSchema7): JSONSchema7 { |
There was a problem hiding this comment.
Should this var have a version number in it? Shouldn't it just be a generic word like "schema"? As the schema version is not relevant to this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of PR on original repo:
Please refer to temando#36
Note: no unit test coverage was introduced as original package pretty much has nearly none and all the necessary setup would be too costly at this stage. Testing is done manually for now - refer to
test/projectfolderPackage will be renamed to @conqa/serverless-openapi-documentation and setup for publishing separately