chore: respond to banner code review#152
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors SSH USERAUTH banner handling to remove duplicated “receive banner(s) then final auth result” loops and makes the FakeSshServer’s banner/failure helpers deterministic by sending packets directly from a suspending function.
Changes:
- Refactor
SshConnectionauth flows to use a sharedreceiveAuthResult()helper that consumesSSH_MSG_USERAUTH_BANNERresults before returning the terminal auth result. - Update
FakeSshServertest helpers to sendUSERAUTH_BANNERandUSERAUTH_FAILUREviasuspendfunctions rather than fire-and-forgetlaunch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sshlib/src/test/kotlin/org/connectbot/sshlib/client/FakeSshServer.kt |
Makes banner/failure packet sends suspending to ensure ordering and avoid background coroutine timing issues in tests. |
sshlib/src/main/kotlin/org/connectbot/sshlib/client/SshConnection.kt |
Deduplicates banner-consumption logic across auth methods via receiveAuthResult(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.