Skip to content

fix: use TrustedRoot from TUF cache for key-based verification #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SequeI wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −21
Open

fix: use TrustedRoot from TUF cache for key-based verification #3218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions internal/policy/policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,32 +459,32 @@ func checkOpts(ctx context.Context, p *policy) (*cosign.CheckOpts, error) {
log.Debug("Using keyless workflow")
log.Debugf("TUF_ROOT=%s", os.Getenv("TUF_ROOT"))
opts.Identities = []cosign.Identity{p.identity}
}

if !hasSigstoreEnvOverrides() {
if trustedRoot, trErr := cosign.TrustedRoot(); trErr == nil {
log.Debug("Using trusted root from TUF for verification")
opts.TrustedMaterial = trustedRoot
} else {
log.Debugf("Could not fetch trusted_root.json from TUF, falling back to individual targets: %v", trErr)
}
if !hasSigstoreEnvOverrides() {
if trustedRoot, trErr := cosign.TrustedRoot(); trErr == nil {
log.Debug("Using trusted root from TUF for verification")
opts.TrustedMaterial = trustedRoot
} else {
log.Debug("Sigstore env overrides detected, skipping trusted root from TUF")
log.Debugf("Could not fetch trusted_root.json from TUF, falling back to individual targets: %v", trErr)
}
} else {
log.Debug("Sigstore env overrides detected, skipping trusted root from TUF")
}

if opts.TrustedMaterial == nil {
if opts.RootCerts, err = fulcio.GetRoots(); err != nil {
return nil, err
}
log.Debug("Fetched Fulcio root certificates")
if opts.IntermediateCerts, err = fulcio.GetIntermediates(); err != nil {
return nil, err
}
log.Debug("Fetched Fulcio intermediate certificates")
if opts.CTLogPubKeys, err = cosign.GetCTLogPubs(ctx); err != nil {
return nil, err
}
log.Debug("Fetched CT log public keys")
if p.PublicKey == "" && opts.TrustedMaterial == nil {
if opts.RootCerts, err = fulcio.GetRoots(); err != nil {
return nil, err
}
log.Debug("Fetched Fulcio root certificates")
if opts.IntermediateCerts, err = fulcio.GetIntermediates(); err != nil {
return nil, err
}
log.Debug("Fetched Fulcio intermediate certificates")
if opts.CTLogPubKeys, err = cosign.GetCTLogPubs(ctx); err != nil {
return nil, err
}
log.Debug("Fetched CT log public keys")
}

opts.IgnoreTlog = p.ignoreRekor
Expand Down
Loading