Skip to content

enable Konflux cache proxy for builds#3112

Open
robnester-rh wants to merge 1 commit intoconforma:release-v0.6from
robnester-rh:EC-1614_v0.6
Open

enable Konflux cache proxy for builds#3112
robnester-rh wants to merge 1 commit intoconforma:release-v0.6from
robnester-rh:EC-1614_v0.6

Conversation

@robnester-rh
Copy link
Contributor

Enable the cache proxy in the Tekton pipeline definitions to improve build performance by caching dependencies.

Ref: EC-1614

Enable the cache proxy in the Tekton pipeline definitions to improve
build performance by caching dependencies.

Ref: EC-1614
Signed-off-by: Rob Nester <rnester@redhat.com>
@qodo-code-review
Copy link
Contributor

Review Summary by Qodo

Enable Konflux cache proxy for container builds

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Enable cache proxy in Tekton pipeline definitions
• Add enable-cache-proxy parameter to build tasks
• Set cache proxy default value to true
• Improve build performance through dependency caching
Diagram
flowchart LR
  A["Pipeline Parameters"] -- "add enable-cache-proxy" --> B["Build Task Configuration"]
  B -- "pass ENABLE_CACHE_PROXY env var" --> C["Build Image Task"]
  C -- "cache dependencies" --> D["Improved Build Performance"]
Loading

Grey Divider

File Changes

1. .tekton/cli-v06-pull-request.yaml ✨ Enhancement +8/-0

Add cache proxy parameter to pull request pipeline

• Added enable-cache-proxy parameter with default value true
• Added parameter definition in pipelineSpec with description
• Passed ENABLE_CACHE_PROXY environment variable to build-image task
• Enables cache proxy for pull request builds

.tekton/cli-v06-pull-request.yaml


2. .tekton/cli-v06-push.yaml ✨ Enhancement +8/-0

Add cache proxy parameter to push pipeline

• Added enable-cache-proxy parameter with default value true
• Added parameter definition in pipelineSpec with description
• Passed ENABLE_CACHE_PROXY environment variable to build-image task
• Enables cache proxy for push builds

.tekton/cli-v06-push.yaml


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Bundle/task param mismatch risk 🐞 Bug ⛯ Reliability
Description
These PipelineRuns pass a new task parameter ENABLE_CACHE_PROXY into an externally-resolved
buildah-oci-ta task pinned by digest; this repo does not include the task spec to verify the param
exists for that digest. If the pinned task version doesn’t define ENABLE_CACHE_PROXY, Tekton will
fail the run when resolving/validating the bundle.
Code

.tekton/cli-v06-pull-request.yaml[R251-252]

+      - name: ENABLE_CACHE_PROXY
+        value: $(params.enable-cache-proxy)
Evidence
Both PipelineRuns define a new Pipeline param enable-cache-proxy and map it into the
buildah-oci-ta Task params as ENABLE_CACHE_PROXY, but the Task is referenced via an external
bundle pinned by digest; without the task definition in-repo, compatibility cannot be confirmed here
and a missing param would block execution.

.tekton/cli-v06-pull-request.yaml[128-131]
.tekton/cli-v06-pull-request.yaml[224-263]
.tekton/cli-v06-push.yaml[223-262]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The PipelineRuns now pass `ENABLE_CACHE_PROXY` into the `buildah-oci-ta` task, but the task definition is external (bundle-resolved) and pinned by digest. If that digest doesn’t define `ENABLE_CACHE_PROXY`, the PipelineRun will fail during resolution/validation.

### Issue Context
The Pipeline param is named `enable-cache-proxy` and is mapped to an uppercase task param `ENABLE_CACHE_PROXY`. Because the task is resolved from a bundle pinned by digest, the only safe way to introduce a new task param is to ensure the pinned digest includes it.

### Fix Focus Areas
- .tekton/cli-v06-pull-request.yaml[251-263]
- .tekton/cli-v06-push.yaml[250-262]
- .tekton/cli-v06-pull-request.yaml[128-131]
- .tekton/cli-v06-push.yaml[127-130]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
generative 70.92% <ø> (ø)
integration 70.92% <ø> (ø)
unit 70.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@simonbaird simonbaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants