Skip to content

Conversation

@conda-forge-linter
Copy link

@conda-forge-linter conda-forge-linter commented Nov 15, 2022

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #598.

Here's a checklist to do before merging.

  • Bump the build number if needed.

Fixes #598
Fixes #600

@conda-forge-linter
Copy link
Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@jakirkham jakirkham changed the title MNT: rerender Drop Circle CI config from recipe Nov 15, 2022
Copy link
Member

@mbargull mbargull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since rerendering updated the compilers on Windows, we should probably bump the build number.

@jakirkham
Copy link
Member

Actually would prefer to put this into a PR that is already going in. Seems silly just to include this change alone (though suppose we could)

@mbargull
Copy link
Member

Yes, makes sense.
(Foremost, I added the review to avoid an early merge -- I'm a fan of the "draft PR" feature ;).)

@mbargull mbargull marked this pull request as draft November 15, 2022 19:42
@jakirkham
Copy link
Member

Yeah it was a bot PR. So it didn't start as a draft, but yeah marking it as such makes sense

@nikhilweee
Copy link
Contributor

Happy to add this in #597

@jakirkham
Copy link
Member

That would be great! Thank you 🙏

@nikhilweee
Copy link
Contributor

Done

@nikhilweee nikhilweee mentioned this pull request Nov 16, 2022
5 tasks
@mattip
Copy link

mattip commented Feb 1, 2023

I think this can be closed.

@jakirkham
Copy link
Member

Why? It appears to be unaddressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove CircleCI config from recipe @conda-forge-admin, please re-render

6 participants