Skip to content

Conversation

@SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Mar 23, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjhelmus
Copy link
Contributor

@conda-forge-admin, please rerender

@SylvainCorlay
Copy link
Member Author

I don't know what's up with the CI on appveyor, but this seems unrelated to us.

@jjhelmus
Copy link
Contributor

LGTM. Going to close and re-open to hopefully re-trigger CI.

@jjhelmus jjhelmus closed this Mar 25, 2020
@jjhelmus jjhelmus reopened this Mar 25, 2020
@SylvainCorlay
Copy link
Member Author

@jjhelmus there seems to be an issue on appveyor over

FileNotFoundError: [WinError 2] The system cannot find the file specified

@SylvainCorlay
Copy link
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2020

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@SylvainCorlay SylvainCorlay force-pushed the backport-regex-fix-3.6 branch from b7797f8 to 8722d97 Compare April 4, 2020 21:33
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@SylvainCorlay
Copy link
Member Author

@jjhelmus @isuruf this is ready to go!

@SylvainCorlay
Copy link
Member Author

@conda-forge/core this is ready to go.

This is a backport of #331 to Pyton 3.6, which was already backported to Python 3.7 in #333.

@jjhelmus jjhelmus merged commit 0f99805 into conda-forge:3.6 Apr 6, 2020
@SylvainCorlay SylvainCorlay deleted the backport-regex-fix-3.6 branch April 6, 2020 14:39
@SylvainCorlay
Copy link
Member Author

Thanks!

@SylvainCorlay
Copy link
Member Author

It seems that the Appveyor build timed out, preventing the windows builds to be uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants