Skip to content

Conversation

@Sparks29032
Copy link
Contributor

@Sparks29032 Sparks29032 commented Dec 18, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@Sparks29032
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@Sparks29032 Sparks29032 marked this pull request as draft December 19, 2025 00:56
@Sparks29032
Copy link
Contributor Author

See diffpy/diffpy.morph#278

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment

recipe/meta.yaml Outdated
source:
url: https://pypi.org/packages/source/d/diffpy_morph/diffpy_morph-{{ version }}.tar.gz
sha256: fe3741623877907f2d5b002b36c0bb3086493008f9e97a40509023165ab9af38
url: https://pypi.org/packages/source/d/diffpy_morph/diffpy_morph-0.3.0.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to have the version hard coded instead of templated. I think we want to go back to the templated version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@sbillinge
Copy link
Contributor

OK, we can bump this to 0.3.1 now. Please update the version and the SHA

@Sparks29032 Sparks29032 changed the title Version 0.3.0 Version 0.3.1 Dec 19, 2025
@Sparks29032 Sparks29032 marked this pull request as ready for review December 19, 2025 03:52
@Sparks29032
Copy link
Contributor Author

@sbillinge Updated.

@sbillinge sbillinge merged commit 6fa8514 into conda-forge:main Dec 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants