Skip to content

Fix: missing accessibility label for back button in SingleWebViewActivity#6604

Merged
rohit9625 merged 5 commits intocommons-app:mainfrom
Kota-Jagadeesh:fix/back-button-accessibility
Feb 25, 2026
Merged

Fix: missing accessibility label for back button in SingleWebViewActivity#6604
rohit9625 merged 5 commits intocommons-app:mainfrom
Kota-Jagadeesh:fix/back-button-accessibility

Conversation

@Kota-Jagadeesh
Copy link
Copy Markdown
Collaborator

@Kota-Jagadeesh Kota-Jagadeesh commented Jan 5, 2026

Description (required)

Changes Made:

  • Replaced an empty contentDescription with the localized string resource R.string.back for the navigation icon in SingleWebViewActivity.
  • Removed the // TODO("Add contentDescription") comment that was tracking this missing accessibility feature.

Tested ProdDebug on Redmi Note 13 Pro with API level 35.

Part of issue #6508

@github-actions
Copy link
Copy Markdown

✅ Generated APK variants!

Copy link
Copy Markdown
Collaborator

@rohit9625 rohit9625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but good for accessibility 👍

@rohit9625 rohit9625 merged commit c04085a into commons-app:main Feb 25, 2026
2 checks passed
Roniscend pushed a commit to Roniscend/apps-android-commons that referenced this pull request Mar 3, 2026
Roniscend pushed a commit to Roniscend/apps-android-commons that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants