Skip to content

use the new TypeDict types from cwl-utils 0.41 more#2192

Merged
mr-c merged 18 commits intomainfrom
try-typed-dicts-from-cwl-utils
Apr 11, 2026
Merged

use the new TypeDict types from cwl-utils 0.41 more#2192
mr-c merged 18 commits intomainfrom
try-typed-dicts-from-cwl-utils

Conversation

@GlassOfWhiskey
Copy link
Copy Markdown
Contributor

@GlassOfWhiskey GlassOfWhiskey commented Dec 13, 2025

This commit checks that the new TypedDict type aliases specified in cwl-utils with PR common-workflow-language/cwl-utils#393 do not break anything in the cwltool type system.

@GlassOfWhiskey GlassOfWhiskey force-pushed the try-typed-dicts-from-cwl-utils branch 9 times, most recently from 614eb80 to 49df34f Compare December 14, 2025 22:51
Comment thread cwltool/cwlviewer.py Outdated
@mr-c mr-c force-pushed the try-typed-dicts-from-cwl-utils branch from 023fe20 to 99d499e Compare December 15, 2025 13:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 89.68254% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.11%. Comparing base (55223a6) to head (a69a035).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cwltool/cwlprov/provenance_profile.py 80.00% 3 Missing and 2 partials ⚠️
cwltool/process.py 88.88% 1 Missing and 2 partials ⚠️
cwltool/command_line_tool.py 92.30% 0 Missing and 2 partials ⚠️
cwltool/cwlprov/ro.py 88.88% 0 Missing and 1 partial ⚠️
cwltool/load_tool.py 85.71% 0 Missing and 1 partial ⚠️
cwltool/utils.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2192      +/-   ##
==========================================
+ Coverage   85.10%   85.11%   +0.01%     
==========================================
  Files          46       46              
  Lines        8561     8567       +6     
  Branches     1993     1996       +3     
==========================================
+ Hits         7286     7292       +6     
  Misses        810      810              
  Partials      465      465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mr-c mr-c force-pushed the try-typed-dicts-from-cwl-utils branch from 2c31446 to 5e0586b Compare December 16, 2025 10:38
mr-c added 5 commits December 16, 2025 11:41
Yes, a bit odd that `class: Directory` objects in `listing` had a `dirname`,
but we are temporarily using that (and fixing them) for setting the outdir when
updating the Pathmapper. Then the `dirname` fields are removed
immediately after.
@mr-c mr-c force-pushed the try-typed-dicts-from-cwl-utils branch from 5e0586b to 8920b7d Compare December 16, 2025 10:52
@mr-c mr-c force-pushed the try-typed-dicts-from-cwl-utils branch from 6a04a0b to 201ce1a Compare December 21, 2025 12:26
@mr-c
Copy link
Copy Markdown
Member

mr-c commented Apr 11, 2026

Whoops, I forgot about this PR when I made #2225 ; here's an attempt to merge it all together

@mr-c mr-c marked this pull request as ready for review April 11, 2026 17:13
@mr-c mr-c force-pushed the try-typed-dicts-from-cwl-utils branch from d44b61e to a69a035 Compare April 11, 2026 17:29
@mr-c mr-c changed the title Experiment with TypedDict in CWL types use the new TypeDict types from cwl-utils 0.41 more Apr 11, 2026
@mr-c mr-c enabled auto-merge (squash) April 11, 2026 17:45
@mr-c mr-c merged commit 5377758 into main Apr 11, 2026
46 checks passed
@mr-c mr-c deleted the try-typed-dicts-from-cwl-utils branch April 11, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants