Skip to content

Conversation

@juhp
Copy link
Member

@juhp juhp commented Jan 2, 2026

This should allow stack to go into nightly and lts25 :-)

Tested locally with stack --resolver nightly --allow-newer.

@juhp
Copy link
Member Author

juhp commented Jan 2, 2026

I don't really understand the failures?

@mpilgrem
Copy link
Member

mpilgrem commented Jan 3, 2026

@juhp, the CI errors are caused by the conflict between the package description file (package.yaml) for stack (which is unchanged) and the stack.cabal file.

@mpilgrem
Copy link
Member

mpilgrem commented Jan 3, 2026

Relaxing the upper bound on persistent is fine. It is only specified to help users of Cabal (the tool):

# package.yaml

# In order for Cabal (the tool) to build Stack, it needs to be told of the
# upper bound on persistent. See
# https://github.com/commercialhaskell/stack/pull/5677#issuecomment-1193318542
- persistent >= 2.14.0.0 && < 2.18

@mpilgrem
Copy link
Member

mpilgrem commented Jan 3, 2026

I have pushed a fixup, as I am about to release Stack 3.9.1 and there is no reason for it not to include this.

@mpilgrem mpilgrem force-pushed the patch-5 branch 2 times, most recently from c9ccee0 to f5c5938 Compare January 3, 2026 23:34
@juhp juhp marked this pull request as ready for review January 4, 2026 05:26
@juhp
Copy link
Member Author

juhp commented Jan 4, 2026

Thanks doh (I often forget about package.yaml, sorry not a particular fan of hpack: I just find the workflow quite confusing/exceptional).

(I saw an old related/similar issue #5753 about the upperbound - maybe that helps to explain it)

(I would venture that most people build stack releases with cabal btw: since it is usually not in stackage (-: )

@mpilgrem mpilgrem merged commit 95d7dfd into commercialhaskell:master Jan 4, 2026
13 checks passed
juhp added a commit to commercialhaskell/stackage that referenced this pull request Jan 5, 2026
@juhp juhp deleted the patch-5 branch January 5, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants