Skip to content

Fix NPE in ParcelMixin.toDraftBuilder #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenschude merged 1 commit into from
Feb 20, 2026
Merged

Fix NPE in ParcelMixin.toDraftBuilder #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...mercetools-sdk-java-api/src/main/java/com/commercetools/api/models/order/ParcelMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
package com.commercetools.api.models.order;

import java.util.List;
import java.util.Optional;

import com.commercetools.api.models.type.CustomFields;

Expand All @@ -19,7 +20,7 @@ public default ParcelDraftBuilder toDraftBuilder() {
.measurements(this.getMeasurements())
.trackingData(this.getTrackingData())
.items(this.getItems())
.custom(this.getCustom().toDraft());
.custom(Optional.ofNullable(this.getCustom()).map(CustomFields::toDraft).orElse(null));
}

public default ParcelDraft toDraft() {
Expand Down
9 changes: 8 additions & 1 deletion commercetools/internal-docs/src/test/java/example/HelperMethodsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,10 +957,17 @@ public void parcelToDraft() {
final ParcelDraft parcelDraft = parcel.toDraft();
}

@Test
public void parcelToDraftBuilder() {
final Parcel parcel = ParcelBuilder.of().id("parcel-id").build();
final Parcel parcel = ParcelBuilder.of()
.id("parcel-id")
.createdAt(ZonedDateTime.now())
.build();

final ParcelDraftBuilder parcelDraftBuilder = parcel.toDraftBuilder();

Assertions.assertNotNull(parcelDraftBuilder);
Assertions.assertNull(parcelDraftBuilder.getCustom());
}

public void deliveryToDraft() {
Expand Down
Loading