Fix path formatting in tokenReplace commands #29
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, `variables.cwd` has the full path and doesn't need a leading "/". Prepending the "/" will cause the `command()` to not work and will silently fail to replace the tokens. Todo: I think the `SetupTemplate.cfc` should be ignored from the token replace command. However, I'm not sure if this is possible.
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows-specific bug in the SetupTemplate.cfc build task where path formatting for the tokenReplace command was incorrect. On Windows, variables.cwd already contains the full absolute path, so prepending a "/" creates an invalid path that causes the token replacement to silently fail.
Changes:
- Removed leading "/" from path parameter in three
tokenReplacecommand calls
Contributor
|
Did you test this in mac/linux? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows,
variables.cwdhas the full path and doesn't need a leading "/". Prepending the "/" will cause thecommand()to not work and will silently fail to replace the tokens.Todo: I think the
SetupTemplate.cfcshould be ignored from the token replace command. However, I'm not sure if this is possibleType of change