Skip to content

Switch iscoroutinefunction from asyncio to inspect #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cottsay merged 1 commit into from
Aug 8, 2025
Merged

Switch iscoroutinefunction from asyncio to inspect #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion colcon_parallel_executor/executor/parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from concurrent.futures import ALL_COMPLETED
from concurrent.futures import FIRST_COMPLETED
from contextlib import suppress
from inspect import iscoroutinefunction
import logging
import os
import signal
Expand Down Expand Up @@ -150,7 +151,7 @@ async def _execute(self, args, jobs, *, on_error):

# pass them to the executor
for package_name, job in take_jobs:
assert asyncio.iscoroutinefunction(job.__call__), \
assert iscoroutinefunction(job.__call__), \
'Job is not a coroutine'
future = asyncio.ensure_future(job())
futures[future] = job
Expand Down
Loading