fix(extraction): handle non-ASCII paths in git fast paths#553
Open
thismilktea wants to merge 1 commit into
Open
fix(extraction): handle non-ASCII paths in git fast paths#553thismilktea wants to merge 1 commit into
thismilktea wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-z/ NUL-delimited parsinggit status --porcelain -zProblem
Files under non-ASCII directory names could be silently skipped during indexing because git fast paths were parsing
human-readable text output rather than machine-readable path output.
When Git returned quoted/escaped non-ASCII paths, CodeGraph could treat that display-format output as a literal file
path and skip the file before it ever reached extraction.
Fix
This PR updates the git-backed scan/change-detection paths in
src/extraction/index.tsto use-zmachine-readableoutput and parse NUL-delimited records instead of newline-delimited text output.
That avoids Git quoted/escaped path output from being treated as a literal path, which restores correct handling for
files under CJK and other non-ASCII directory names.
Test plan
npx vitest run __tests__/extraction.test.ts -t "issue #541"npx vitest run __tests__/sync.test.ts -t "CJK directories via git"npm run buildClose #541