Skip to content

Fix documentation inconsistencies, typos, and numbering issues#446

Closed
jeffbrownn wants to merge 6 commits intocoinbase:masterfrom
jeffbrownn:master-patch-01
Closed

Fix documentation inconsistencies, typos, and numbering issues#446
jeffbrownn wants to merge 6 commits intocoinbase:masterfrom
jeffbrownn:master-patch-01

Conversation

@jeffbrownn
Copy link
Copy Markdown

What changed? Why?

  1. Fixed step numbering in packages/illustrations/README.md:
  • Duplication of step 2 has been eliminated.
  • The sequence of steps has been corrected.
  1. Corrected typo errors in cds-web.mdc, theme.ts, CHANGELOG.md:
  • deafult -> default
  • elemenet -> element
  • human-redable -> human-readable
  • upadate -> update
  • FullscreenMoal -> FullscreenModal
  1. Fixed incorrect wording in AGENTS.md:
    run the unit -> run the unit tests
    I clarified the wording to make it grammatically correct and clearly refer to unit tests.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@hcopp
Copy link
Copy Markdown
Contributor

hcopp commented Feb 26, 2026

Hey @jeffbrownn thanks for the PR, can you

  1. Run yarn nx format:write
  2. Run yarn bump-version, select common and do internal for the update type? You can say you were correcting a typo, include this PR #, and ignore Jira ticket
  3. Add the following to PR description:
## Illustrations/Icons Checklist

Required if this PR changes files under `packages/illustrations/**` or `packages/icons/**`

- [x] verified visreg changes with Terran (include link to visreg run/approval)
- [x] all illustration/icons names have been reviewed by Dom and/or Terran

@hcopp hcopp mentioned this pull request Mar 2, 2026
8 tasks
@hcopp
Copy link
Copy Markdown
Contributor

hcopp commented Mar 2, 2026

Was able to update in #456 , thanks again for the help!

@hcopp hcopp closed this Mar 2, 2026
@jeffbrownn
Copy link
Copy Markdown
Author

Was able to update in #456 , thanks again for the help!

Sorry for not responding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants