feat(cds 1615) deprecate dangerouslySetBackground/dangerouslySetColor props#427
Merged
haoruikun-cb merged 3 commits intocds-v9from Feb 27, 2026
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
haoruikun-cb
force-pushed
the
harryhao/cds-1615-deprecate-dangerouslysetbackgrounddangerouslysetcolor-props
branch
from
ddc4d2a to
ffe334f
Compare
haoruikun-cb
changed the title
haoruikun-cb
commented
Feb 24, 2026
| ) { | ||
| const rootStyleOverride = styles?.root; | ||
|
|
||
| const rootStyle = useMemo<PressableProps['style']>(() => { |
Contributor
Author
There was a problem hiding this comment.
The Pressable style prop could be a function, so we are doing check like this
haoruikun-cb
force-pushed
the
harryhao/cds-1615-deprecate-dangerouslysetbackgrounddangerouslysetcolor-props
branch
3 times, most recently
from
574dfe7 to
be2ba27
Compare
stacysun-cb
reviewed
Feb 27, 2026
haoruikun-cb
force-pushed
the
harryhao/cds-1615-deprecate-dangerouslysetbackgrounddangerouslysetcolor-props
branch
from
be2ba27 to
88e1403
Compare
stacysun-cb
approved these changes
Feb 27, 2026
haoruikun-cb
deleted the
harryhao/cds-1615-deprecate-dangerouslysetbackgrounddangerouslysetcolor-props
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
https://linear.app/coinbase/issue/CDS-1615/deprecate-dangerouslysetbackgrounddangerouslysetcolor-props
Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
For a comprehensive test, we will rely on visreg when we compare final v9 branch against the master
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false