Skip to content

chore: Remove React Spring from SlideButton APIs#419

Merged
adrienzheng-cb merged 3 commits intocds-v9from
spring-apis
Feb 27, 2026
Merged

chore: Remove React Spring from SlideButton APIs#419
adrienzheng-cb merged 3 commits intocds-v9from
spring-apis

Conversation

@cb-ekuersch
Copy link
Copy Markdown
Contributor

What changed? Why?

Linear: https://linear.app/coinbase/issue/CDS-1617/remove-any-react-spring-types-from-prop-interfaces

Later in H1 we will fully remove react-spring and replace with the platform appropriate paved roads (motion & reanimated). Before then, while we prepare a set of breaking changes for v9, we must ensure no react spring types remain in our component APIs. Any such components should be rewritten now to use the proper paved road libraries.

Claude did an excellent job refactoring. Unit tests passing, manual visual testing on iphone and android are looking good!

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@linear
Copy link
Copy Markdown

linear Bot commented Feb 22, 2026

@cb-ekuersch cb-ekuersch force-pushed the spring-apis branch 2 times, most recently from 426cf80 to 41d9f91 Compare February 23, 2026 00:06
@adrienzheng-cb adrienzheng-cb merged commit bea8fe5 into cds-v9 Feb 27, 2026
15 checks passed
@adrienzheng-cb adrienzheng-cb deleted the spring-apis branch February 27, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants