Skip to content

[V8] Ingesting no datapoints no longer raises an exception #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MortGron wants to merge 1 commit into from
Closed

[V8] Ingesting no datapoints no longer raises an exception #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cognite/client/_api/datapoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2326,6 +2326,8 @@ def __init__(self, dps_client: DatapointsAPI) -> None:

def insert(self, dps_object_lst: list[dict[str, Any]]) -> None:
to_insert = self._verify_and_prepare_dps_objects(dps_object_lst)
if not to_insert:
return
# To ensure we stay below the max limit on objects per request, we first chunk based on it:
# (with 10k limit this is almost always just one chunk)
tasks = [
Expand All @@ -2344,15 +2346,14 @@ def _verify_and_prepare_dps_objects(
) -> list[tuple[Identifier, list[_InsertDatapoint]]]:
dps_to_insert: dict[Identifier, list[_InsertDatapoint]] = defaultdict(list)
for obj in dps_object_lst:
if not obj["datapoints"]:
continue
identifier = validate_user_input_dict_with_identifier(obj, required_keys={"datapoints"})
validated_dps = self._parse_and_validate_dps(obj["datapoints"])
dps_to_insert[identifier].extend(validated_dps)
return list(dps_to_insert.items())

def _parse_and_validate_dps(self, dps: Datapoints | DatapointsArray | list[tuple | dict]) -> list[_InsertDatapoint]:
if not dps:
raise ValueError("No datapoints provided")

if isinstance(dps, Datapoints):
self._verify_dps_object_for_insertion(dps)
return self._extract_raw_data_from_datapoints(dps)
Expand Down
8 changes: 5 additions & 3 deletions tests/tests_unit/test_api/test_datapoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,11 @@ def test_insert_datapoints_over_limit(self, cognite_client, mock_post_datapoints
"items": [{"id": 1, "datapoints": [{"timestamp": int(i * 1e11), "value": i} for i in range(6, 11)]}]
} in request_bodies

def test_insert_datapoints_no_data(self, cognite_client):
with pytest.raises(ValueError, match="No datapoints provided"):
cognite_client.time_series.data.insert(id=1, datapoints=[])
@pytest.mark.parametrize("datapoints, id", [([], 1), (Datapoints(id=1), 1)])
def test_insert_datapoints_no_data(
self, cognite_client: CogniteClient, datapoints: list | Datapoints, id: int | None
):
cognite_client.time_series.data.insert(datapoints=datapoints, id=id)

def test_insert_datapoints_in_multiple_time_series(self, cognite_client, mock_post_datapoints):
dps = [{"timestamp": i * 1e11, "value": i} for i in range(1, 11)]
Expand Down
Loading