Skip to content

Fix comment thread expansion if its title contains clickable elements#2037

Merged
Oaphi merged 3 commits intodevelopfrom
0valt/2036/comment-thread-expansion-fix
Apr 4, 2026
Merged

Fix comment thread expansion if its title contains clickable elements#2037
Oaphi merged 3 commits intodevelopfrom
0valt/2036/comment-thread-expansion-fix

Conversation

@Oaphi
Copy link
Copy Markdown
Member

@Oaphi Oaphi commented Apr 2, 2026

closes #2036

Also makes sure we do not replace the inline thread with the fetched content unless the response indicates success (most likely solves meta:295715, but let's make sure every case is covered in a separate PR).

As a treat, it also ensures MathJax stays properly rendered upon collapsing previously opened comment threads.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.88%. Comparing base (7b6dfd1) to head (78b5da0).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 76.18% <ø> (ø)
helpers 85.09% <ø> (ø)
jobs 66.88% <ø> (ø)
models 93.04% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi
Copy link
Copy Markdown
Member Author

Oaphi commented Apr 2, 2026

Let's do a production deployment upon review & merge

@Oaphi Oaphi marked this pull request as ready for review April 2, 2026 05:24
@Oaphi Oaphi requested review from a team, ArtOfCode-, cellio and trichoplax April 2, 2026 05:24
@Oaphi Oaphi added this to the v0.12.5 milestone Apr 2, 2026
Copy link
Copy Markdown
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me.

Before the fix, in a dev environment I got what looks like a stack trace rather than a 404, so I'm not sure how to test the "maybe also fixes" issue. But we can check that case after deploying this and see if it's still an issue.

@Oaphi
Copy link
Copy Markdown
Member Author

Oaphi commented Apr 3, 2026

Before the fix, in a dev environment I got what looks like a stack trace rather than a 404

That's the exact same error, @cellio, it's just that in development mode the ErrorsController is not invoked by default (for the dev to be able to see the trace and other info). In production, the same error results in the 404 error page being served.

@Oaphi Oaphi merged commit d694b97 into develop Apr 4, 2026
13 checks passed
@Oaphi Oaphi deleted the 0valt/2036/comment-thread-expansion-fix branch April 4, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment thread inline expansion breaks if the title contains clickable content such as MathJax

3 participants