feat(grouper): add counters to the grouper worker

[e11sy]

Problem

This is the part of the work on sentry counters issue

Sentry events trigger counters (chart) increments and then are silently dismissed in sentry worker

this leads to invalid charts behaviour

Solution

Move charts update to the grouper to guarantee that we increment counters after the moment, when event is stored in the db

Moved charts redis time series logic to grouper RedisHelper

Note

Make sure to check this collector PR also

[codex-assistant]

Please add a PR description 🙂

Respect the reviewers — a description helps others understand the changes and review them faster. Keep it short, clear, and to the point. It also serves as documentation for future reference.

The PR was moved to Draft until a description is added.

[codex-assistant]

Please add a PR description 🙂

Respect the reviewers — a description helps others understand the changes and review them faster. Keep it short, clear, and to the point. It also serves as documentation for future reference.

The PR was moved to Draft until a description is added.

[codex-assistant]

Please add a PR description 🙂

Respect the reviewers — a description helps others understand the changes and review them faster. Keep it short, clear, and to the point. It also serves as documentation for future reference.

The PR was moved to Draft until a description is added.

[codex-assistant]

Please add a PR description 🙂

Respect the reviewers — a description helps others understand the changes and review them faster. Keep it short, clear, and to the point. It also serves as documentation for future reference.

The PR was moved to Draft until a description is added.

[codex-assistant]

Thanks for adding a description — the PR is now marked as Ready for Review.

[Copilot]

Pull request overview

This PR moves “events accepted” counter updates into the Grouper worker so project charts are updated only after an event is persisted, and introduces RedisTimeSeries helper methods to support that flow.

Changes:

• Add RedisTimeSeries helper methods (TS.CREATE, TS.ADD, TS.INCRBY) with “safe” wrappers that create series on-demand.
• Record events-accepted metrics (minutely/hourly/daily) at the end of GrouperWorker.handle.
• Add tests asserting the three writes happen, failures are logged without breaking processing, and metrics are recorded once per event.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
workers/grouper/tests/index.test.ts	Adds tests validating metrics writes and failure behavior.
workers/grouper/src/redisHelper.ts	Adds RedisTimeSeries command helpers and safe wrappers.
workers/grouper/src/index.ts	Records project metrics (3 granularities) after event handling.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

buildLabelArguments always returns ['LABELS'] even when labels is empty. Because tsAdd/tsIncrBy default labels = {}, this can generate RedisTimeSeries commands ending with a bare LABELS token, which Redis will reject as a wrong-arity command. Consider returning an empty array when there are no labels (or make labels required for these public methods).

[e11sy]

we never pass empty labels object

[Copilot]

tsCreateIfNotExists does a separate EXISTS check and then TS.CREATE. Under concurrency, two workers can both observe the key as missing and then one of the TS.CREATE calls will fail with "key already exists", which currently bubbles up and causes the metric write to be dropped. Consider handling the "already exists" error from TS.CREATE (treat as success) or using an atomic pattern so concurrent creation is safe.

Suggested change

	await this.redisClient.sendCommand(args);
	try {
	await this.redisClient.sendCommand(args);
	} catch (error) {
	/**
	* Handle race condition where another worker created the key between
	* the EXISTS check and TS.CREATE. In that case, RedisTimeSeries will
	* return an error like "ERR TSDB: key already exists". We can safely
	* treat this as success.
	*/
	if (
	error instanceof Error &&
	/key already exists/i.test(error.message)
	) {
	return;
	}
	throw error;
	}

[e11sy]

rewritten to lua