Skip to content

Replace BreadcrumbLevel and BreadcrumbType enums with String to accept arbitrary SDK values #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dobrunia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace BreadcrumbLevel and BreadcrumbType enums with String to accept arbitrary SDK values #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "hawk.api",
"version": "1.4.3",
"version": "1.4.4",
"main": "index.ts",
"license": "BUSL-1.1",
"scripts": {
Expand Down
35 changes: 8 additions & 27 deletions src/typeDefs/event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,29 +116,6 @@ type EventUser {
photo: String
}

"""
Breadcrumb severity level
"""
enum BreadcrumbLevel {
fatal
error
warning
info
debug
}

"""
Breadcrumb type - controls categorization and UI appearance
"""
enum BreadcrumbType {
default
request
ui
navigation
logic
error
}

"""
Single breadcrumb entry - represents an event that occurred before the error
"""
Expand All @@ -149,9 +126,11 @@ type Breadcrumb {
timestamp: Float!

"""
Type of breadcrumb - controls UI categorization
Type of breadcrumb - controls UI categorization.
Common values: default, request, ui, navigation, logic, error.
Accepts any string since SDK users may send custom types.
"""
type: BreadcrumbType
type: String

"""
Category of the event - more specific than type
Expand All @@ -164,9 +143,11 @@ type Breadcrumb {
message: String

"""
Severity level of the breadcrumb
Severity level of the breadcrumb.
Common values: fatal, error, warning, info, debug.
Accepts any string since SDK users may send custom levels.
"""
level: BreadcrumbLevel
level: String

"""
Arbitrary key-value data associated with the breadcrumb
Expand Down
Loading