fix: Backspaces do not work when the code block contains initial data.

[yosipy]

fix: editor-js/code#75

editor-js/code#67

When we add a new code block, backspace works.

1.mp4

However, when updating a code block with initial data, backspaces do not work.

      const editorConfig = {
        data: {
          blocks: [
            
            {
              type: "code",
              data: {
                code: 'console.log("ssss")',
              },
            },
          ],

2.mp4

Cause

The value of the argument input of function isCaretAtStartOfInput (src/components/utils/caret.ts) is as follows when there is no initial value.

<textarea class="ce-code__textarea cdx-input" placeholder="Enter a code" data-empty="false"></textarea>

When there is an initial value, the value is as follows.

<textarea class="ce-code__textarea cdx-input" placeholder="Enter a code" data-empty="false">console.log("ssss")</textarea>

firstNode is the string 'console.log(“ssss”)' and isCaretAtStartOfInput()==true.

Solution

When the argument input is native input, firstNode is assigned input.

[neSpecc]

I'd suggest to update getDeepestNode instead. It already contains a logic that will return a passed node, but seems like node[child] statement does not cover this case

[yosipy]

Thank you for pointing it out.
I think you are right too.

Fixed in 8cec5c9.

[yosipy]

@neSpecc
Please re-review.

[neSpecc]

seems ok, please add a line to the changelog

[yosipy]

@neSpecc

Yes, I added it.

[CasFreriks]

When will this pull request be reviewed? It's a pretty annoying bug.

[neSpecc]

Hey, @yosipy would you please, add a test for this case?

[yosipy]

I've been busy lately and don't have time to fix the code.