Also check root node for mutationFree attribute#2164
Closed
oskarer wants to merge 2 commits intocodex-team:nextfrom
Closed
Also check root node for mutationFree attribute#2164oskarer wants to merge 2 commits intocodex-team:nextfrom
oskarer wants to merge 2 commits intocodex-team:nextfrom
Conversation
neSpecc
requested changes
Nov 25, 2022
oskarer
added a commit
to Teamtailor/editor.js
that referenced
this pull request
Nov 29, 2022
Member
|
It would be great to have a test case for that change. I think we'll include it in the upcoming release. |
Author
@neSpecc Thanks, can you give me any pointers where a great place would be to add a spec for it? At least I've rebased now so it's mergeable. |
Member
I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to set
mutationFreeon any element added in therender()function, not just added or removed child nodes. For example this case which I encountered (not a full example, somewhat psuedo code);This would trigger the
onChangeevent sincelite-youtubeis a custom element that adds a lot of elements to the DOM afterrender()has run. But in reality nothing has really changed, the only thing that should trigger a change is change of the video URL in the<input>field.