feat: upstream port v2.6→v3.8.5 + skill & workflow upgrade

[codewithkenzo]

Summary

Complete upstream port of oh-my-opencode v2.6→v3.8.5 features into the Kenzo fork, plus a skill & workflow upgrade layer on top. 36 commits, 197 files changed.

Upstream Port (35 commits)

Phase 1 — Foundation

• .sisyphus → .musashi rename across entire codebase
• 18 broken skill names fixed in CATEGORY_SKILLS
• Background-first delegation and kenzo-* skill priority enforced in agent prompts

Phase 2 — Tools & Config

• Hashline-edit tool + tool-metadata-store ported
• MODEL_VERSION_MAP auto-migration (opus-4-5 → opus-4-6)
• safeCreateHook utility + experimental config fields

Phase 3 — Hooks

• 6 upstream hooks ported: hashline-read-enhancer, hashline-edit-diff-enhancer, write-existing-file-guard, anthropic-effort, unstable-agent-babysitter, runtime-fallback (13 files)
• Comment-checker extended with apply_patch support
• 6 new hooks wired into plugin registration

Phase 4 — Agents

• Intent verbalization in Musashi + trust-no-one verification in Atlas
• Display name mapping for all agents
• Cascade cancel for background child sessions
• /handoff context continuity command

Phase 5 — Agent Architecture

• Dynamic-agent-prompt-builder for metadata-driven prompt sections
• AgentMode type + model detection upgrades
• D5 backend-builder enhanced with completion guarantee
• Atlas modularized into model-specific prompt variants

Phase 6 — Infrastructure

• SQLite backend detection with flat-file fallback
• Tool metadata store
• Task tool ported alongside delegate-task
• TmuxConfigSchema with layout options

Phase 7 — Agent Identity

• kenzo-* skills assigned to R2, T4, D5 metadata
• K9 advisor upgraded with upstream Oracle improvements
• Agent skill specializations shown in Musashi prompt

Skill & Workflow Upgrade (squash-merged from PR #30)

• Enforcement hooks: ticket-enforcement, verification-before-completion, skill-auto-invoke, todo-ticket-bridge (all default to "warn")
• Git worktree tools: worktree_list, worktree_create, worktree_remove, worktree_switch
• Safety hooks: rm-to-trash (intercepts rm → mv to trash)
• Slash commands: /brainstorm, /worktree, /review, /debug, /verify, /finish
• Agent prompts: Verification + Skill Awareness sections, TDD Discipline for builders
• Test pollution fix: mock.module() conditional gate pattern for Bun tests

Test results

1642 pass, 0 fail, 1 skip, 132 test files, 4662 expect() calls

[github-actions]

Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA).

To sign the CLA, please comment on this PR with:

I have read the CLA Document and I hereby sign the CLA

This is a one-time requirement. Once signed, all your future contributions will be automatically accepted.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[greptile-apps]

Greptile Summary

Complete upstream port of oh-my-opencode v2.6→v3.8.5 (35 commits) plus skill & workflow upgrade layer. Major additions:

Infrastructure (High Quality)

• Runtime fallback system with model switching on 429/503/529 errors, cooldown tracking, and cascade cancel for nested background tasks
• 6 enforcement hooks (ticket tracking, rm-to-trash, verification gate, skill auto-invoke) all default to "warn" mode
• Git worktree tools with create/list/remove/status operations
• Hashline-edit tool with hash validation and diff enhancement
• Dynamic agent prompt builder with metadata-driven sections

Migration & Config (Solid)

• Comprehensive v2.6→v3.8.5 migration with automatic backups and model version upgrades (opus-4-5 → opus-4-6)
• Schema extensions for all new hooks, properly typed with Zod
• Agent name normalization (Sisyphus→Musashi, Oracle→K9, etc.)

Test Coverage (Excellent)

• 1642 passing tests across 133 test files
• Cascade cancel, runtime fallback, enforcement hooks all covered

Issue Found

• hashline-edit-executor.ts:132-135 — rename doesn't check if target exists, will silently overwrite

Confidence Score: 4/5

• Safe to merge after fixing rename overwrite issue in hashline-edit-executor.ts
• Excellent test coverage (1642 passing), well-structured architecture, comprehensive migration logic. One logic bug found (file rename can silently overwrite) prevents 5/5 score, but otherwise implementation quality is high
• src/tools/hashline-edit/hashline-edit-executor.ts (rename logic needs fix)

Important Files Changed

Filename	Overview
src/hooks/runtime-fallback/event-handler.ts	Handles session lifecycle events for model fallback on errors. Proper cleanup on session.deleted/stop, correct error detection and retry logic.
src/features/background-agent/manager.ts	Cascade cancel for nested background tasks implemented correctly. Collects all descendants before cleanup to prevent dangling tasks.
src/tools/hashline-edit/hashline-edit-executor.ts	File editing with hash validation and rename support. Missing check for existing file at rename target path (lines 132-135) could cause silent overwrite.
src/hooks/ticket-enforcement/hook.ts	Enforces ticket tracking before code changes. Proper tool filtering, session state management, and enforcement level handling.
src/tools/worktree/tools.ts	Git worktree management with create/list/remove/status operations. Proper error handling, branch detection, and dirty-state checking.
src/agents/atlas/agent.ts	Model-specific orchestrator prompt builder. Clean separation of GPT/Gemini/default prompts, proper tool restrictions applied.
src/shared/migration.ts	Config migration from v2.6 to v3.8.5. Comprehensive name mapping, automatic model version upgrades, proper backup before write.
src/config/schema.ts	Schema additions for new hooks and features. All properly typed with Zod, sensible defaults, backward compatibility maintained.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    Start[User Request] --> Atlas[Atlas Orchestrator]
    Atlas --> Delegate[delegate_task]
    
    Delegate --> SkillCheck{Skill Available?}
    SkillCheck -->|Yes| InvokeSkill[Invoke Skill]
    SkillCheck -->|No| AgentSelect[Select Agent by Category]
    
    AgentSelect --> Background[Background Manager]
    Background --> Concurrency{Check Concurrency}
    Concurrency -->|Slot Available| Launch[Launch Agent Session]
    Concurrency -->|Queue Full| Queue[Queue Task]
    
    Launch --> Execute[Execute Task]
    Execute --> Error{Session Error?}
    Error -->|429/503/529| Fallback[Runtime Fallback]
    Error -->|Other| Fail[Report Error]
    Error -->|Success| Complete[Task Complete]
    
    Fallback --> FallbackState{Fallback Available?}
    FallbackState -->|Yes| Retry[Retry with Fallback Model]
    FallbackState -->|Max Attempts| Fail
    Retry --> Execute
    
    Complete --> Verify{Verification Hook}
    Verify -->|Tests Run| AtlasResult[Return to Atlas]
    Verify -->|No Tests| Warn[Warn Missing Verification]
    Warn --> AtlasResult
    
    AtlasResult --> MoreTasks{More Tasks?}
    MoreTasks -->|Yes| Delegate
    MoreTasks -->|No| Done[All Tasks Complete]
    
    Launch -.->|session.deleted| CascadeCancel[Cascade Cancel]
    CascadeCancel --> Descendants[Cancel All Descendants]
    Descendants --> Cleanup[Cleanup State]

Loading

_{Last reviewed commit: c54a168}

[greptile-apps]

_{196 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

rename target path not checked for existence — will silently overwrite if file already exists at rename path

Suggested change

	if (rename && rename !== filePath) {
	await Bun.write(rename, writeContent)
	await Bun.file(filePath).delete()
	}
	if (rename && rename !== filePath) {
	const renameFile = Bun.file(rename)
	if (await renameFile.exists()) {
	return `Error: Rename target already exists: ${rename}`
	}
	await Bun.write(rename, writeContent)
	await Bun.file(filePath).delete()
	}

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/tools/hashline-edit/hashline-edit-executor.ts
Line: 132-135

Comment:
rename target path not checked for existence — will silently overwrite if file already exists at `rename` path

```suggestion
    if (rename && rename !== filePath) {
      const renameFile = Bun.file(rename)
      if (await renameFile.exists()) {
        return `Error: Rename target already exists: ${rename}`
      }
      await Bun.write(rename, writeContent)
      await Bun.file(filePath).delete()
    }
```

How can I resolve this? If you propose a fix, please make it concise.