Actions menus #2346
Merged
Actions menus #2346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare EditConfigurationView to support additional actions beyond delete. The actions dropdown can be extended by subclasses to add custom menu items like duplicate. REDMINE-21205
Extract getActionsMenuItems() method to allow subclasses to provide custom menu items. Add getDestroyMenuItem() with separated option for adding visual separators. REDMINE-21205
Extract menu item models to reusable SectionMenuItems module with factory function. Both EditSectionView and SectionItemView now use the same menu items for duplicate, insert, hide/show, cutoff, and copy permalink actions. Move related translations to section_menu_items namespace and remove misplaced translations from main pageflow locales. REDMINE-21205
Make destructive actions more obvious by showing a red background on hover. The delete menu item in configuration views now uses this style. REDMINE-21205
Allow EditConfigurationView subclasses to provide custom delete menu items with type-specific confirmation messages and destroy behavior. Views can override getActionsMenuItems to return custom menu items. EditConfigurationView now listens to model destroy events to navigate back automatically. REDMINE-21205
Make ForeignKeySubsetCollection automatically update when an item's foreign key attribute changes. This enables moving items between collections by simply changing the foreign key value, without manually removing from source and adding to target. Also fix parent reference handling when moving items between collections - the old collection's remove handler no longer overwrites the reference that was just set by the new collection. REDMINE-41070
Add actions menu item in chapter edit view to toggle between main storyline and excursions. This makes it easy for editors to reorganize content without having to delete and recreate chapters. REDMINE-41070
Indicate to editors that a section is hidden outside of the editor to prevent confusion about why content might not appear in the published entry. Also add icon support to InfoBoxView for visual emphasis. REDMINE-41070
Allow subclasses to override which model is passed to ConfigurationEditorView. By default returns model.configuration, but can be overridden to return model directly for views that edit plain Backbone models instead of configuration containers.
Sidebar views for editing collection items (external links, hotspot areas, image gallery items) now extend EditConfigurationView instead of duplicating its boilerplate. Delete actions are moved to the actions dropdown menu and use DestroyMenuItem. Allow views to specify which model event triggers back navigation. Defaults to 'destroy'. Sidebar edit views for collection items (hotspot areas, gallery items, external links) override to 'remove' since they use collection.remove() for deletion. modelLifecycleTrackingView is made defensive about missing failureTracking methods. REDMINE-21205
Post SET_ACTIVE_AREA command with index -1 to clear the active area highlight in the preview when leaving the area edit view.
Allow users to quickly create a copy of a content element with identical type and configuration. The duplicate is inserted directly after the original and automatically selected. REDMINE-21205
Allow duplicating individual paragraphs within text blocks using the content element duplicate action. Text blocks override the default duplication behavior to duplicate only the selected Slate nodes rather than the entire content element. The duplicated nodes are automatically selected afterwards. REDMINE-21205
Show "Delete selection" and "Duplicate selection" labels when text block handles the action itself (operating on selected paragraphs rather than the whole element). Also make section duplicate label more explicit. REDMINE-21205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-21205