feat(argocd): add install pc-apps command#442
Open
Jcing95 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Jcing95 <23337729+Jcing95@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new beta CLI subcommand to install/upgrade the pc-apps Helm chart from a private OCI registry, including support for merging multiple values files and adding Helm registry authentication plumbing.
Changes:
- Introduces
internal/installer/pc_apps.goimplementing install/upgrade logic for thepc-appsOCI Helm chart, including YAML values deep-merge. - Extends
HelmClientwithLoginRegistryand wires registry login into Helm environment creation; updates generated mocks accordingly. - Adds
oms beta install pc-appscobra command and corresponding documentation pages/links.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
internal/installer/pc_apps.go |
New installer for pc-apps OCI chart with registry auth + values merge. |
internal/installer/pc_apps_test.go |
Ginkgo tests covering install/upgrade flows, URL validation, and values merging. |
internal/installer/mocks.go |
Updates generated MockHelmClient to include LoginRegistry. |
internal/installer/helm_client.go |
Adds LoginRegistry to interface and hooks registry login into Helm env setup. |
docs/oms_beta_install.md |
Adds docs index entry for the new pc-apps install command. |
docs/oms_beta_install_pc-apps.md |
Adds generated docs page for oms beta install pc-apps. |
cli/cmd/pc_apps.go |
Adds cobra command implementation and flag handling for installing pc-apps. |
cli/cmd/beta_install.go |
Registers the new pc-apps command under oms beta install. |
Files not reviewed (1)
- internal/installer/mocks.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+86
to
+93
| func (h *helmClient) LoginRegistry(_ context.Context, host, username, password string) error { | ||
| h.registryCreds = ®istryCredentials{ | ||
| host: host, | ||
| username: username, | ||
| password: password, | ||
| } | ||
| return nil | ||
| } |
Comment on lines
+96
to
+101
| If not set, it will be prompted interactively (hidden input).`), | ||
| Example: formatExamples("install pc-apps", []packageio.Example{ | ||
| {Cmd: "--chart oci://ghcr.io/codesphere-cloud/charts/pc-apps --version 1.0.0 --username CodesphereBot", Desc: "Install a specific version (prompts for password)"}, | ||
| {Cmd: "--chart oci://ghcr.io/codesphere-cloud/charts/pc-apps --username CodesphereBot -f base.yaml -f dc-overlay.yaml", Desc: "Install latest with multiple values files"}, | ||
| {Cmd: "--chart oci://ghcr.io/codesphere-cloud/charts/pc-apps --username CodesphereBot --namespace custom-ns", Desc: "Install into a custom namespace"}, | ||
| }), |
Comment on lines
+22
to
+28
| $ oms install pc-apps --chart oci://ghcr.io/codesphere-cloud/charts/pc-apps --version 1.0.0 --username CodesphereBot | ||
|
|
||
| # Install latest with multiple values files | ||
| $ oms install pc-apps --chart oci://ghcr.io/codesphere-cloud/charts/pc-apps --username CodesphereBot -f base.yaml -f dc-overlay.yaml | ||
|
|
||
| # Install into a custom namespace | ||
| $ oms install pc-apps --chart oci://ghcr.io/codesphere-cloud/charts/pc-apps --username CodesphereBot --namespace custom-ns |
Comment on lines
+22
to
+29
| type InstallPCAppsOpts struct { | ||
| *GlobalOptions | ||
| Chart string | ||
| Version string | ||
| Namespace string | ||
| Username string | ||
| ValuesFiles []string | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.