feat(bootstrap): Add Telemetry settings to codesphere config#433
Open
BBesrour wants to merge 7 commits into
Open
feat(bootstrap): Add Telemetry settings to codesphere config#433BBesrour wants to merge 7 commits into
BBesrour wants to merge 7 commits into
Conversation
Signed-off-by: BBesrour <58034472+BBesrour@users.noreply.github.com>
joka134
requested changes
May 21, 2026
Comment on lines
+322
to
+329
| if b.Env.CentralOtelPassword != "" || b.Env.LocalTraceExport { | ||
| b.Env.InstallConfig.Codesphere.TelemetryExport = &files.TelemetryExport{ | ||
| Endpoint: b.Env.CentralOtelEndpoint, | ||
| RemoteExport: b.Env.CentralOtelPassword != "", | ||
| Traces: b.Env.LocalTraceExport, | ||
| SpanMetrics: b.Env.CentralOtelSpanMetrics, | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Can we add some verification to give users some feedback, when these flags are partially configured but ignored by oms? Should be done atm in gcp.go.
Like password and LocalTraceExport was configured but no endpoint
Member
Author
There was a problem hiding this comment.
We have default value in case export is enabled but no import specified. But added some check for creds and endpoint
Signed-off-by: BBesrour <58034472+BBesrour@users.noreply.github.com>
Signed-off-by: BBesrour <58034472+BBesrour@users.noreply.github.com>
joka134
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for configuring telemetry export.
Adds new command-line flags to enable sending traces and span metrics