Buildfile improvements

[mernst]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request adds a new Makefile target java/ChicoryPremain.jar that delegates to the java subdirectory to build the ChicoryPremain.jar artifact. Additionally, it introduces a TODO comment in the java Makefile regarding Java target configuration, adds a "Note: " prefix to a logging message in BuildJDK.java during class instrumentation progress reporting, and suppresses removal-related warnings in a test framework class with an annotation.

Possibly related PRs

• Treat recursive make correctly #755: Modifies Makefile rules that invoke sub-make in the java subdirectory to use ${MAKE} variable instead of hardcoded make invocations.
• Update Makefile #736: Directly related as it modifies Makefile targets to add and build ChicoryPremain.jar as a public target.

Suggested reviewers

• markro49

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@Makefile`:
- Around line 727-729: The make target "java/ChicoryPremain.jar" is currently a
no-op once the jar exists; change it to always delegate by adding a dummy force
prerequisite and marking that prerequisite phony (e.g. add a "FORCE" empty
target and add "java/ChicoryPremain.jar: FORCE" and ".PHONY: FORCE"), so the
recipe "${MAKE} -C java ChicoryPremain.jar" runs every time and avoids stale
builds.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 114d503 and 8fb971e.

📒 Files selected for processing (4)

• Makefile
• java/Makefile
• java/daikon/dcomp/BuildJDK.java
• tests/sources/junit/framework/TestResult.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: codespecs.daikon (typecheck_latest_part1_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_part2_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_part3_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_part3_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_part2_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (quick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_part1_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (kvasir_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (misc_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nonquick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nontxt_ubuntu_jdk25)

🔇 Additional comments (3)

java/daikon/dcomp/BuildJDK.java (1)

503-508: Log prefix change is fine.
No functional impact; message clarity is improved.

java/Makefile (1)

66-66: Comment-only note looks good.
No build behavior changes introduced.

tests/sources/junit/framework/TestResult.java (1)

122-123: Scoped suppression is appropriate.
Limited to the method; no behavior change.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}