Skip to content

SANDBOX-1357: update kube & openshift dependencies to 4.19 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsoaresd merged 11 commits into from
Sep 16, 2025
Merged

SANDBOX-1357: update kube & openshift dependencies to 4.19 #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6347957
fix
rsoaresd May 6, 2025
8565e07
Merge branch 'codeready-toolchain:master' into master
rsoaresd Jul 27, 2025
beefdef
Merge branch 'codeready-toolchain:master' into master
rsoaresd Sep 2, 2025
8cf8ac3
Merge branch 'codeready-toolchain:master' into master
rsoaresd Sep 4, 2025
4dd5101
SANDBOX-1357: update kube & openshift dependencies to 4.19
Sep 4, 2025
bd44b83
improvements
Sep 4, 2025
9aaf9ac
improve
Sep 4, 2025
766fb1c
improvements
Sep 4, 2025
ce08642
improvement
Sep 4, 2025
3a4084c
upgrade golang.org/x/net
rsoaresd Sep 9, 2025
270447f
Merge branch 'master' into openshift_4_19_api
rsoaresd Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ linters:
- testifylint
- unparam
- zerologlint
- copyloopvar
disable:
- contextcheck
- noctx
Expand Down
8 changes: 1 addition & 7 deletions .govulncheck.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1 @@
ignored-vulnerabilities:
# Inconsistent handling of O_CREATE|O_EXCL on Unix and Windows in os in syscall
# Found in: os@go1.22.12
# Fixed in: os@go1.23.10
- id: GO-2025-3750
silence-until: 2025-10-02
info: https://pkg.go.dev/vuln/GO-2025-3750
ignored-vulnerabilities: []
2 changes: 1 addition & 1 deletion README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ For the API reference docs go xref:api/v1alpha1/docs/apiref.adoc[here]
== Building
Requires:

* Go version 1.22.x (1.22.12 or higher) - download for your development environment https://golang.org/dl/[here].
* Go version 1.23.x (1.23.12 or higher) - download for your development environment https://golang.org/dl/[here].

CodeReady ToolChain API is built using https://github.com/golang/go/wiki/Modules[Go modules].

Expand Down
52 changes: 26 additions & 26 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
module github.com/codeready-toolchain/api

go 1.22.0
go 1.23.0

toolchain go1.22.12
toolchain go1.23.12

Comment on lines +3 to 6
Copy link

@coderabbitai coderabbitai bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Go 1.23 toolchain pin: confirm CI/tooling image matches go1.23.12.

With toolchain go1.23.12, older builders will fetch a toolchain at build time; ensure hermetic environments already use 1.23.12.

🏁 Script executed:

#!/bin/bash
go version
go env GOVERSION 2>/dev/null || true

Length of output: 72

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "CI workflow files in .github/workflows:"
find .github/workflows -type f -maxdepth 2 || true

echo
echo "actions/setup-go entries:"
grep -R "actions/setup-go" -n .github/workflows || true

echo
echo "go-version parameters in workflows:"
grep -R "go-version" -n .github/workflows || true

echo
if [ -f .circleci/config.yml ]; then
  echo "CircleCI Docker image references:"
  grep -R "image:" -n .circleci/config.yml || true
fi

echo
if [ -f .gitlab-ci.yml ]; then
  echo "GitLab CI Docker image references:"
  grep -R "image:" -n .gitlab-ci.yml || true
fi

Length of output: 1079

🌐 Web query:

Does GitHub Actions setup-go v5 support the go.mod 'toolchain' directive when using go-version-file?

💡 Result:

Short answer: No. setup-go v5 reads the go directive from go.mod/go.work via go-version-file but does not act on the go.mod "toolchain" directive; see the action README and the open issue requesting toolchain support. [1][2]

Workarounds: explicitly set go-version or set GOTOOLCHAIN=local in the step's env. [2]

Explicitly pin Go 1.23.12 in CI workflows
actions/setup-go@v5’s go-version-file: go.mod reads only the go directive (1.23.0) and ignores the toolchain directive, so CI is installing 1.23.0 (or falling back to the runner’s Go 1.24.1) instead of 1.23.12. Update each workflow to:

  • replace 
    with:
  uses: actions/setup-go@v5
  go-version-file: go.mod
    with 
    with:
  uses: actions/setup-go@v5
  go-version: 1.23.12

in .github/workflows/ci-build.yml (line 23), govulncheck.yml (lines 19/24), and verify-dependencies.yml (line 19).

🤖 Prompt for AI Agents 
In go.mod around lines 3 to 6, the go directive is 1.23.0 while the toolchain is
1.23.12; update each GitHub Actions workflow to explicitly pin Go 1.23.12 by
replacing the actions/setup-go@v5 usage that references go-version-file: go.mod
with a go-version: 1.23.12 argument — specifically edit
.github/workflows/ci-build.yml (around line 23),
.github/workflows/govulncheck.yml (around lines 19 and 24), and
.github/workflows/verify-dependencies.yml (around line 19) to use with: uses:
actions/setup-go@v5 and go-version: 1.23.12 so CI installs the intended Go
toolchain.

require (
github.com/go-bindata/go-bindata v3.1.2+incompatible
// using latest commit from 'github.com/openshift/api branch release-4.18'
github.com/openshift/api v0.0.0-20250410062700-d6c84c55a124
k8s.io/api v0.31.2
k8s.io/apimachinery v0.31.2
k8s.io/code-generator v0.31.2
// using latest commit from 'github.com/openshift/api branch release-4.19'
github.com/openshift/api v0.0.0-20250903165707-ce7baf0afbc4
k8s.io/api v0.32.2
k8s.io/apimachinery v0.32.2
k8s.io/code-generator v0.32.2
k8s.io/gengo v0.0.0-20230829151522-9cce18d56c01
k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340
sigs.k8s.io/controller-runtime v0.19.7
sigs.k8s.io/controller-tools v0.16.5
k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f
sigs.k8s.io/controller-runtime v0.20.4
sigs.k8s.io/controller-tools v0.17.3
)

require (
github.com/emicklei/go-restful/v3 v3.11.0 // indirect
github.com/fatih/color v1.18.0 // indirect
github.com/fxamacker/cbor/v2 v2.7.0 // indirect
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-openapi/jsonpointer v0.19.6 // indirect
github.com/go-openapi/jsonpointer v0.21.0 // indirect
github.com/go-openapi/jsonreference v0.20.2 // indirect
github.com/go-openapi/swag v0.22.4 // indirect
github.com/go-openapi/swag v0.23.0 // indirect
github.com/gobuffalo/flect v1.0.3 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/protobuf v1.5.4 // indirect
Expand All @@ -38,24 +38,24 @@ require (
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/spf13/cobra v1.8.1 // indirect
github.com/spf13/pflag v1.0.5 // indirect
github.com/spf13/cobra v1.9.1 // indirect
github.com/spf13/pflag v1.0.6 // indirect
github.com/x448/float16 v0.8.4 // indirect
golang.org/x/mod v0.21.0 // indirect
golang.org/x/net v0.33.0 // indirect
golang.org/x/sync v0.10.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
golang.org/x/tools v0.26.0 // indirect
google.golang.org/protobuf v1.34.2 // indirect
golang.org/x/mod v0.23.0 // indirect
golang.org/x/net v0.38.0 // indirect
golang.org/x/sync v0.12.0 // indirect
golang.org/x/sys v0.31.0 // indirect
golang.org/x/text v0.23.0 // indirect
golang.org/x/tools v0.30.0 // indirect
google.golang.org/protobuf v1.35.1 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/apiextensions-apiserver v0.31.2 // indirect
k8s.io/gengo/v2 v2.0.0-20240228010128-51d4e06bde70 // indirect
k8s.io/apiextensions-apiserver v0.32.2 // indirect
k8s.io/gengo/v2 v2.0.0-20240911193312-2b36238f13e9 // indirect
k8s.io/klog/v2 v2.130.1 // indirect
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 // indirect
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect
sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect
sigs.k8s.io/yaml v1.4.0 // indirect
)
Loading
Loading