Skip to content

fix: parse Coder authorities with Punycode (xn--) domain labels #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EhabY merged 2 commits into from
May 6, 2026
+164 −74
Merged

fix: parse Coder authorities with Punycode (xn--) domain labels #930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fbeb00
fix: parse Coder authorities with Punycode (xn--) domain labels
EhabY May 4, 2026
d96535c
Add changelog entry
EhabY May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
from published versions since it shows up in the VS Code extension changelog
tab and is confusing to users. Add it back between releases if needed. -->

## Unreleased

### Fixed

- Workspaces hosted on internationalized (IDN) domains can now be opened from
recent connections. The SSH authority parser was splitting Punycode (`xn--`)
domain labels across the field separator and rejecting the host as invalid.

## [v1.14.5](https://github.com/coder/vscode-coder/releases/tag/v1.14.5) 2026-04-30

### Added
Expand Down
6 changes: 6 additions & 0 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ export function parseRemoteAuthority(authority: string): AuthorityParts | null {
return null;
}

// Reassemble Punycode labels (xn--...) the split broke apart: when the
// prefix ends in ".xn", the cut landed inside an "xn--..." label.
while (parts.length >= 2 && parts[0].endsWith(".xn")) {
parts.splice(0, 2, `${parts[0]}--${parts[1]}`);
}

Comment thread
EhabY marked this conversation as resolved.
// It has the proper prefix, so this is probably a Coder host name.
// Validate the SSH host name. Including the prefix, we expect at least
// three parts, or four if including the agent.
Expand Down
224 changes: 150 additions & 74 deletions test/unit/util.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import os from "node:os";
import { afterEach, beforeEach, describe, it, expect, vi } from "vitest";

import {
type AuthorityParts,
countSubstring,
escapeCommandArg,
expandPath,
Expand All @@ -13,84 +14,159 @@ import {
} from "@/util";

describe("parseRemoteAuthority", () => {
it("ignore unrelated authorities", () => {
const tests = [
"vscode://ssh-remote+some-unrelated-host.com",
"vscode://ssh-remote+coder-vscode",
"vscode://ssh-remote+coder-vscode-test",
"vscode://ssh-remote+coder-vscode-test--foo--bar",
"vscode://ssh-remote+coder-vscode-foo--bar",
"vscode://ssh-remote+coder--foo--bar",
];
for (const test of tests) {
expect(parseRemoteAuthority(test)).toBe(null);
}
it.each([
"vscode://ssh-remote+some-unrelated-host.com",
"vscode://ssh-remote+coder-vscode",
"vscode://ssh-remote+coder-vscode-test",
"vscode://ssh-remote+coder-vscode-test--foo--bar",
"vscode://ssh-remote+coder-vscode-foo--bar",
"vscode://ssh-remote+coder--foo--bar",
])("ignores unrelated authority: %s", (input) => {
expect(parseRemoteAuthority(input)).toBe(null);
});

it("should error on invalid authorities", () => {
const tests = [
"vscode://ssh-remote+coder-vscode--foo",
"vscode://ssh-remote+coder-vscode--",
"vscode://ssh-remote+coder-vscode--foo--",
"vscode://ssh-remote+coder-vscode--foo--bar--",
];
for (const test of tests) {
expect(() => parseRemoteAuthority(test)).toThrow("Invalid");
}
it.each([
"vscode://ssh-remote+coder-vscode--foo",
"vscode://ssh-remote+coder-vscode--",
"vscode://ssh-remote+coder-vscode--foo--",
"vscode://ssh-remote+coder-vscode--foo--bar--",
])("rejects invalid authority: %s", (input) => {
expect(() => parseRemoteAuthority(input)).toThrow("Invalid");
});

it("should parse authority", () => {
expect(
parseRemoteAuthority("vscode://ssh-remote+coder-vscode--foo--bar"),
).toStrictEqual({
agent: "",
sshHost: "coder-vscode--foo--bar",
safeHostname: "",
username: "foo",
workspace: "bar",
});
expect(
parseRemoteAuthority("vscode://ssh-remote+coder-vscode--foo--bar--baz"),
).toStrictEqual({
agent: "baz",
sshHost: "coder-vscode--foo--bar--baz",
safeHostname: "",
username: "foo",
workspace: "bar",
});
expect(
parseRemoteAuthority(
"vscode://ssh-remote+coder-vscode.dev.coder.com--foo--bar",
),
).toStrictEqual({
agent: "",
sshHost: "coder-vscode.dev.coder.com--foo--bar",
safeHostname: "dev.coder.com",
username: "foo",
workspace: "bar",
});
expect(
parseRemoteAuthority(
"vscode://ssh-remote+coder-vscode.dev.coder.com--foo--bar--baz",
),
).toStrictEqual({
agent: "baz",
sshHost: "coder-vscode.dev.coder.com--foo--bar--baz",
safeHostname: "dev.coder.com",
username: "foo",
workspace: "bar",
});
expect(
parseRemoteAuthority(
"vscode://ssh-remote+coder-vscode.dev.coder.com--foo--bar.baz",
),
).toStrictEqual({
agent: "baz",
sshHost: "coder-vscode.dev.coder.com--foo--bar.baz",
safeHostname: "dev.coder.com",
username: "foo",
workspace: "bar",
});
interface ParseCase {
label: string;
input: string;
expected: AuthorityParts;
}

it.each<ParseCase>([
{
label: "legacy form, no agent",
input: "vscode://ssh-remote+coder-vscode--foo--bar",
expected: {
agent: "",
sshHost: "coder-vscode--foo--bar",
safeHostname: "",
username: "foo",
workspace: "bar",
},
},
{
label: "legacy form with agent",
input: "vscode://ssh-remote+coder-vscode--foo--bar--baz",
expected: {
agent: "baz",
sshHost: "coder-vscode--foo--bar--baz",
safeHostname: "",
username: "foo",
workspace: "bar",
},
},
{
label: "with hostname, no agent",
input: "vscode://ssh-remote+coder-vscode.dev.coder.com--foo--bar",
expected: {
agent: "",
sshHost: "coder-vscode.dev.coder.com--foo--bar",
safeHostname: "dev.coder.com",
username: "foo",
workspace: "bar",
},
},
{
label: "with hostname and -- agent",
input: "vscode://ssh-remote+coder-vscode.dev.coder.com--foo--bar--baz",
expected: {
agent: "baz",
sshHost: "coder-vscode.dev.coder.com--foo--bar--baz",
safeHostname: "dev.coder.com",
username: "foo",
workspace: "bar",
},
},
{
label: "with hostname and . agent",
input: "vscode://ssh-remote+coder-vscode.dev.coder.com--foo--bar.baz",
expected: {
agent: "baz",
sshHost: "coder-vscode.dev.coder.com--foo--bar.baz",
safeHostname: "dev.coder.com",
username: "foo",
workspace: "bar",
},
},
{
label: "Punycode label in hostname",
input:
"vscode://ssh-remote+coder-vscode.dev.coder.xn--eckwd4c7cu47r2wf.jp--foo--bar",
expected: {
agent: "",
sshHost: "coder-vscode.dev.coder.xn--eckwd4c7cu47r2wf.jp--foo--bar",
safeHostname: "dev.coder.xn--eckwd4c7cu47r2wf.jp",
username: "foo",
workspace: "bar",
},
},
{
label: "Punycode hostname with -- agent",
input:
"vscode://ssh-remote+coder-vscode.xn--eckwd4c7cu47r2wf.jp--foo--bar--baz",
expected: {
agent: "baz",
sshHost: "coder-vscode.xn--eckwd4c7cu47r2wf.jp--foo--bar--baz",
safeHostname: "xn--eckwd4c7cu47r2wf.jp",
username: "foo",
workspace: "bar",
},
},
{
label: "Punycode hostname with . agent",
input:
"vscode://ssh-remote+coder-vscode.xn--eckwd4c7cu47r2wf.jp--foo--bar.baz",
expected: {
agent: "baz",
sshHost: "coder-vscode.xn--eckwd4c7cu47r2wf.jp--foo--bar.baz",
safeHostname: "xn--eckwd4c7cu47r2wf.jp",
username: "foo",
workspace: "bar",
},
},
{
label: "multiple Punycode labels",
input: "vscode://ssh-remote+coder-vscode.xn--abc.xn--def.com--foo--bar",
expected: {
agent: "",
sshHost: "coder-vscode.xn--abc.xn--def.com--foo--bar",
safeHostname: "xn--abc.xn--def.com",
username: "foo",
workspace: "bar",
},
},
{
label: "apex Punycode",
input: "vscode://ssh-remote+coder-vscode.xn--p1ai--owner--ws",
expected: {
agent: "",
sshHost: "coder-vscode.xn--p1ai--owner--ws",
safeHostname: "xn--p1ai",
username: "owner",
workspace: "ws",
},
},
{
label: "consecutive apex Punycode labels",
input: "vscode://ssh-remote+coder-vscode.xn--p1ai.xn--abc--owner--ws",
expected: {
agent: "",
sshHost: "coder-vscode.xn--p1ai.xn--abc--owner--ws",
safeHostname: "xn--p1ai.xn--abc",
username: "owner",
workspace: "ws",
},
},
])("parses $label", ({ input, expected }) => {
expect(parseRemoteAuthority(input)).toStrictEqual(expected);
});
});

Expand Down
Loading