Support VS Code's built-in proxy settings #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EhabY
force-pushed
the
support-vs-code-proxy-settings
branch
2 times, most recently
from
2c996d8 to
11d7ce4
Compare
mafredri
approved these changes
Jan 27, 2026
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
One minor concern, but otherwise LGTM.
Add support for VS Code's proxy settings that were not previously respected: - http.noProxy: Falls back when coder.proxyBypass is not set - http.proxyAuthorization: Passed directly as Proxy-Authorization header - http.proxyStrictSSL: Combined with coder.insecure for TLS verification Also fixes a bug in proxy.ts where the scheme condition was inverted, causing schemes to be added when they already existed.
EhabY
force-pushed
the
support-vs-code-proxy-settings
branch
from
11d7ce4 to
b81501b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for VS Code's proxy settings that were not previously respected:
Also fixes a bug in proxy.ts where the scheme condition was inverted, causing schemes to be added when they already existed.
Fixes #755