derphttp: add GetHeaders callback for dynamic auth headers#117
Merged
deansheather merged 1 commit intocoder:mainfrom May 6, 2026
Merged
derphttp: add GetHeaders callback for dynamic auth headers#117deansheather merged 1 commit intocoder:mainfrom
deansheather merged 1 commit intocoder:mainfrom
Conversation
ibdafna
force-pushed
the
nflx/derp-get-headers
branch
from
ee4bbb4 to
c5b5cce
Compare
Adds an optional GetHeaders callback to derphttp.Client that, when non-nil, is invoked on every (re)connect to obtain a fresh set of HTTP headers for the DERP upgrade request. When set, it takes precedence over the existing static Header field. This is useful for callers that need to inject short-lived authentication tokens (e.g. for an authenticating reverse proxy in front of DERP) that must be refreshed on each reconnect rather than captured once at startup. The same pattern already exists on netcheck.Client.GetDERPHeaders. magicsock plumbs the callback through Conn.derpGetHeaders / Conn.SetDERPGetHeaders, mirroring the existing SetDERPHeader pathway. Backward compatible: GetHeaders == nil (the default) preserves the existing Header behavior; existing callers see no change.
ibdafna
force-pushed
the
nflx/derp-get-headers
branch
from
c5b5cce to
c22782f
Compare
deansheather
approved these changes
May 6, 2026
Member
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional GetHeaders callback to
derphttp.Clientthat, when non-nil, is invoked on every (re)connect to obtain a fresh set of HTTP headers for the DERP upgrade request. When set, it takes precedence over the existing static Header field.This is useful for callers that need to inject short-lived authentication tokens (e.g. for an authenticating reverse proxy in front of DERP) that must be refreshed on each reconnect rather than captured once at startup. The same pattern already exists on
netcheck.Client.GetDERPHeaders.magicsockplumbs the callback throughConn.derpGetHeaders/Conn.SetDERPGetHeaders, mirroring the existingSetDERPHeaderpathway.Backward compatible:
GetHeaders == nil(the default) preserves the existing Header behavior; existing callers see no change.This code was authored with Cursor under my supervision